Re: [PATCH gwproxy v1 3/3] dnslookup: Initial work for implementation of C-ares-like getaddrinfo function

[Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>]

On Fri, Aug 1, 2025 at 8:52 AM reyuki wrote:
> On Fri, Aug 1, 2025 at 2:15 AM Alviro Iskandar Setiawan wrote:
> > On Thu, Jul 31, 2025 at 10:09 AM Ahmad Gani wrote:
> > > +static int resolve_name(int sockfd, const char *name, uint16_t type, uint16_t nport,
> > > +       struct gw_ares_addrinfo *result, struct gw_addrinfo_node **tail)
> > > +{
> > > +       uint8_t send_buff[UDP_MSG_LIMIT];
> > > +       uint8_t recv_buff[UDP_MSG_LIMIT];
> > > +       gwdns_query_pkt *query_pkt;
> > > +       gwdns_answ_data raw_answ;
> > > +       gwdns_question_part q;
> > > +       ssize_t buff_len;
> > > +       int ret;
> > > [...]
> > > +attempt_retry:
> > > +       ret = __sys_send(sockfd, send_buff, buff_len, MSG_NOSIGNAL);
> > > +       if (ret < 0) {
> > > +               ret = GW_ARES_INTERNAL_ERR;
> > > +               return ret;
> > > +       }
> > > +
> > > +       if (ret != buff_len)
> > > +               goto attempt_retry;
> >
> > Why is this attempt_retry needed?
>
> Oh, do you mean short send is not possible in blocking socket? Sorry for
> the confusion, I think I'm not aware of that fact. I will remove it.

I didn't say that. I asked because I don't know.

-- Viro