From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1757141264; bh=xK0BcwpVr3j75aSSwkiXoZVwGjknfAsfsiz0Gm0HHsM=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=qlhAD3XbWGOYGlw7IhmaZfGcozAi2ch6FAAFfdoR8yI165ByPlQvgi3sWK2k+CEHL AkXUXkuitQCtBUlm0g/c28qtZZGj6vQCpDLjzL8oozBDvlTcNScoo8vatXfa1vueXs +HIbN1CPYW6aomkas9wYsUW1fXYSfIiWJRzfjMqKw0gKpMXfkKwJpbv7cRqBSD35R7 YtsTYlKKa5HgDkZJs04F9PyoSp8Ufzao1BH1nug+x5Hi2FLrpXxiYZwGfdBAkQ6VlM 1uPpGGedj7MuEJUDFfLXnB6ohpvC8+iRnajA8vn7yLa7qRQES2MlXaBwoeABCPKU7b WE1T3YvihYHdQ== Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 9C18A3127AA3 for ; Sat, 6 Sep 2025 06:47:44 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-32b7d165dc6so2561046a91.3 for ; Fri, 05 Sep 2025 23:47:44 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXm1Ah39MmUgSSRkwFfTft72U0b63m0BtDMd6GXMBtVw7Wg1+Ia94Xh+535OayRtgboBKAX@vger.gnuweeb.org X-Gm-Message-State: AOJu0YzoljGo3irg8mSec+TrfgfsZATwwTp7lDHRto6vl6t+RoZfnMim GJJdzyLIR9Dre6Yg7KdWMxESK374Gk8R8tfV50ut84HEfPMWeCdHxv2Ii64WqCeUytZ8p0dRZPa U+g5y5vI5bt5knPNtMABHV6gscpYsJIc= X-Google-Smtp-Source: AGHT+IEHedBFd57bI6wqy8qH1ANN1R7U/aNzjOhYMRFijeAzgCC5RuT1f+er1dx5TMkz/xpPDQNoOmlWw/TTAZ5KV0g= X-Received: by 2002:a17:90a:da88:b0:32b:c610:6f01 with SMTP id 98e67ed59e1d1-32d43f17c3cmr2212936a91.16.1757141263012; Fri, 05 Sep 2025 23:47:43 -0700 (PDT) MIME-Version: 1.0 References: <20250829075557.598176-1-reyuki@gnuweeb.org> <20250829075557.598176-3-reyuki@gnuweeb.org> In-Reply-To: From: Alviro Iskandar Setiawan Date: Sat, 6 Sep 2025 13:47:31 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXyBo39Af1DPlSgQEwTkL5u5iq2_FSX3L7_CFQ0vJ_7C6NZzNFT8oaHMiHo Message-ID: Subject: Re: [PATCH gwproxy v8 2/2] gwproxy: refactor code base to add experimental raw DNS backend To: Ahmad Gani Cc: Ammar Faizi , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Sat, Sep 6, 2025 at 11:33=E2=80=AFAM Ahmad Gani wro= te: > I thought it was necessary to mark that a certain block belongs to the > experimental raw DNS feature. If I reduce the use of these marks, it migh= t > introduce unnecessary code into the compiled version when this experiment= al > feature is disabled. It's necessary, but you're overusing it. Your version clutters the codebase so much. You had better have empty local functions which are compiled to nothing instead of #ifdef/#endif everywhere. Look at https://git.kernel.org/pub/scm/linux/kernel/git/axboe/liburing.git/tree/src= /include/liburing/sanitize.h?id=3D5baeec1e1200b88da1d84ba978605728d791d693