From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alviro.iskandar@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS,
	URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no
	version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1754461369;
	bh=T+Co7artCXtrd3ae6KlhgqR03cm32+0khBxwTdayjiA=;
	h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
	 To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From:
	 Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date:
	 Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type:
	 Content-Transfer-Encoding;
	b=g5LzM5Y951kgqZ3pJ6KwWIZfA4tISBc1L5TN1rz0s6CEJa+q2lj4MSHwEzJtgL41O
	 hLQbK2OmCjyAiPWFvdVrSuBvKiCGWO1U55nsFZJNrSti2atF5P5pR4i3+uJymUfMl0
	 lfJyTo1xOo+wyN1c7403zg+wE+3BoKTFq8UGSDlRAUVuhbgTWeXayplKrVzKH8oxOs
	 zL2+KOqpz9xdHOhU1HxNHJCXZDBaU1+bpB3QsC0z+N4tciKbV/eVb7NN2NRsmIJxYG
	 MDGc4R2GIbImBCBSsUh5c4CNaYM8SLRo2tqYZafE7XTEe0mvtJyisP9gjYh3uQWQXR
	 eFlXg9sBfZysw==
Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 9DF803127C3E
	for <gwml@vger.gnuweeb.org>; Wed,  6 Aug 2025 06:22:49 +0000 (UTC)
Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-31f28d0495fso6862427a91.1
        for <gwml@vger.gnuweeb.org>; Tue, 05 Aug 2025 23:22:49 -0700 (PDT)
X-Forwarded-Encrypted: i=1; AJvYcCXoH6ujReZ0NdcXhJZBNTUvBrdhbo7afvM57l827+VtXOCP2blZSohaBwT3XpyYKVKH0FvD@vger.gnuweeb.org
X-Gm-Message-State: AOJu0Yy3KZ1FIGgin0VXjuE7aZmJukuo0tsvKWALk+2ub4VqX7TKRV48
	VOCSzkG2bP9gaS1qqZuFdbCHuk8RH0Uo4mb0sd4YmIuTN4WyetampL8Dc0UrineqT5r73tEFuK4
	nUJNnHJLQTs/r+WN7nevO/tjpMvwOXAs=
X-Google-Smtp-Source: AGHT+IEbwfAwujbTZMOH7TROf3alIrypeaenz9obFrerrYFV3e+g9ttPzXcvMjgZRroW9nmLdkqh6YUJeRaULjZHbKs=
X-Received: by 2002:a17:90b:2dcd:b0:312:1ae9:152b with SMTP id
 98e67ed59e1d1-32166cc6b5amr1782836a91.23.1754461368023; Tue, 05 Aug 2025
 23:22:48 -0700 (PDT)
MIME-Version: 1.0
References: <20250806035727.216702-1-reyuki@gnuweeb.org> <20250806035727.216702-7-reyuki@gnuweeb.org>
In-Reply-To: <20250806035727.216702-7-reyuki@gnuweeb.org>
From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Date: Wed, 6 Aug 2025 13:22:37 +0700
X-Gmail-Original-Message-ID: <CAOG64qN8QeUB+tgEirrVRrbF+mcb+n7D_22NcCw0tRLCi2eU6w@mail.gmail.com>
X-Gm-Features: Ac12FXx52GFoLcxBM-2D39HrZ090-_CFVN0mvmZE-P3uUn_gv01cHQUF7HmSP-E
Message-ID: <CAOG64qN8QeUB+tgEirrVRrbF+mcb+n7D_22NcCw0tRLCi2eU6w@mail.gmail.com>
Subject: Re: [PATCH gwproxy v4 6/6] dnslookup: Make gw_ares_getaddrinfo asynchronous
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>, "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <gwml.vger.gnuweeb.org>

On Wed, Aug 6, 2025 at 10:57=E2=80=AFAM Ahmad Gani wrote:
> @@ -122,7 +122,8 @@ int serialize_answ(uint16_t txid, uint8_t *in, size_t=
 in_len, gwdns_answ_data *o
>         if (!out->rr_answ)
>                 return -ENOMEM;
>
> -       for (size_t i =3D 0; i < hdr->ancount; i++) {
> +       size_t i;
> +       for (i =3D 0; i < hdr->ancount; i++) {

This kind of change should be squashed. And var declaration should be
placed on the top.

-- Viro