From: Alviro Iskandar Setiawan <[email protected]>
To: Memet Zx <[email protected]>
Cc: Ammar Faizi <[email protected]>,
Muhammad Rizki <[email protected]>,
Irvan Malik Azantha <[email protected]>,
"GNU/Weeb Mailing List" <[email protected]>
Subject: Re: [PATCH WEB 0/4] Add custom scrollbar styles and refactor layout styles
Date: Sun, 2 Jun 2024 18:06:29 +0700 [thread overview]
Message-ID: <CAOG64qN8dQZS+0uYU8AbOsVinjzStY3aK_mMaonmp-eXSHKyfg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
On Sun, Apr 21, 2024 at 9:25 PM Memet Zx wrote:
> Hello,
>
> This patch series adds custom scrollbar styles to app.css and refactors
> layout styles in OrganizationMembers.svelte, RecentMessages.svelte, and
> +page.svelte. It also adds a description to site.webmanifest.
You can take a look at Muhammad Rizki's series, it's a good example of
patchset that meets our standards:
https://lore.gnuweeb.org/gwml/[email protected]/T/
GNU/Weeb has its own standard in code review, and your patchset is
definitely far from ours.
Also, use a real name. I don't believe "Zx" is a valid name (correct
me if I am wrong). As per DCO, one important requirement is that each
patch (or commit, in the case of a git pull request) must contain a
valid "Signed-off-by:" line using your real name. We unfortunately
cannot accept pseudonymous or anonymous contributions.
-- Viro
prev parent reply other threads:[~2024-06-02 11:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-21 14:24 [PATCH WEB 0/4] Add custom scrollbar styles and refactor layout styles Memet Zx
2024-04-21 14:24 ` [PATCH WEB 1/4] Add custom scrollbar styles to app.css Memet Zx
2024-06-02 10:47 ` Ammar Faizi
2024-04-21 14:24 ` [PATCH WEB 2/4] Update layout styles in +layout.svelte Memet Zx
2024-04-21 14:24 ` [PATCH WEB 3/4] Refactor layout styles in OrganizationMembers.svelte, RecentMessages.svelte, and +page.svelte Memet Zx
2024-04-21 14:24 ` [PATCH WEB 4/4] Add description to site.webmanifest Memet Zx
2024-06-02 10:33 ` [PATCH WEB 0/4] Add custom scrollbar styles and refactor layout styles Ammar Faizi
2024-06-02 11:06 ` Alviro Iskandar Setiawan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOG64qN8dQZS+0uYU8AbOsVinjzStY3aK_mMaonmp-eXSHKyfg@mail.gmail.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox