From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1717326401; bh=HweFiPiUG/CQEsxAr7wByo/b6zfaI5p4QzEZhv1w6nE=; h=References:In-Reply-To:From:Date:Subject:To:Cc; b=MAsAhG/isI2gxhEKvkTbKLOb0V5wsNkugqjpazb5Na7/2tKs0AjEveQucvwAThxk9 aEJbpFVAV/y9NVNuzLrGyI6N+uoEukLUuFakqz9651Xb6uds3vD9FB5X9KkkeliGBY IazkRcDvFhamobNadx240YVbjdwB0mYoQSg+3rm1gTeWJgP+gS2yXEz8LUq0shnQm0 Kx14KAjHG4rZ2VBJ2vYCN9Ciumwe73LNsZ3U3uhveihP0PI3+3Yh4gdXH64lkjipN3 H4FU0gf133HnTmBGQWT3MgTA0Me5/BML4pP52NKVrmZNhb43ibeQrXhtR7FM8EH5gZ jcpIrAUWwANlw== Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by gnuweeb.org (Postfix) with ESMTPSA id D4C002370EA for ; Sun, 2 Jun 2024 18:06:41 +0700 (WIB) Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2c195eb9af3so2572672a91.0 for ; Sun, 02 Jun 2024 04:06:41 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWSeRw934GW1fhshFMKHpp8qx+YlMVlT8fYYVuhL6An7B5EdCwP9k4f8anPvjqGBWoqiSVQaZ9VlAlWtpUtM8hNfd6g9SY= X-Gm-Message-State: AOJu0YzsuDO9i3pwa46IXGnJEcahSbz118p8iHQLkI5FeR3HIoca3LYZ fBP56o09EhHoTMPMCBZr4kRB0fuW1TXahI+8fQn8TpRpHmvZu4VoqrZn3AiFqENwkkDl53tnx66 pbH4gofYMmDY7rTqFk9kk+JdlcwU= X-Google-Smtp-Source: AGHT+IGX83sRRMIozRCRMKAQdIsklAKChScw+8SYEeeaLxw8n1zcVsLnGsarkffREsNSgIAnZNKZnYysMCaoglq7j1A= X-Received: by 2002:a17:90a:bd92:b0:2bd:d42a:e199 with SMTP id 98e67ed59e1d1-2c1dc56dc9bmr5840240a91.9.1717326401490; Sun, 02 Jun 2024 04:06:41 -0700 (PDT) MIME-Version: 1.0 References: <20240421142436.476337-1-zxce3@gnuweeb.org> In-Reply-To: <20240421142436.476337-1-zxce3@gnuweeb.org> From: Alviro Iskandar Setiawan Date: Sun, 2 Jun 2024 18:06:29 +0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH WEB 0/4] Add custom scrollbar styles and refactor layout styles To: Memet Zx Cc: Ammar Faizi , Muhammad Rizki , Irvan Malik Azantha , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Sun, Apr 21, 2024 at 9:25=E2=80=AFPM Memet Zx wrote: > Hello, > > This patch series adds custom scrollbar styles to app.css and refactors > layout styles in OrganizationMembers.svelte, RecentMessages.svelte, and > +page.svelte. It also adds a description to site.webmanifest. You can take a look at Muhammad Rizki's series, it's a good example of patchset that meets our standards: https://lore.gnuweeb.org/gwml/20231007054446.1204-1-kiizuha@gnuweeb.org/T= / GNU/Weeb has its own standard in code review, and your patchset is definitely far from ours. Also, use a real name. I don't believe "Zx" is a valid name (correct me if I am wrong). As per DCO, one important requirement is that each patch (or commit, in the case of a git pull request) must contain a valid "Signed-off-by:" line using your real name. We unfortunately cannot accept pseudonymous or anonymous contributions. -- Viro