From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alviro.iskandar@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS,
	URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no
	version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1754091839;
	bh=OaYoXprBu16+3wBDhITsAPlVfbyviczGvb7BGyT3a4Y=;
	h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
	 To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From:
	 Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date:
	 Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type:
	 Content-Transfer-Encoding;
	b=lipKPE2V3Mqgu/H383GLVB0zmFbHQbXIdz5GD8Yqi/AQxENc9zRJC0EaCdNe/zepE
	 mj2NOMTeUmAzdcukZTfuTk6bfc+7bmaDvc/RC353VmLkUwjuQY6JcwD3+Ubxz4GuiO
	 mE9YaJuCdJ4lGvs1o+DZuGOyCS4i3T4++96C0xqMziWQJ/1TScN7ykhHulf0+3to8t
	 WgNwWadrJqL+7GPmczR0vbMdlZBdt+4bM1eMNBex6R53S0ZalCWOBB6+a2PFxHEiDG
	 zOATP5EprfHDd9D2Nt3Jm1NV8qkNDrOuyuSe4AnuhYX1gogCbQIu19YvkgMEIOnEzl
	 YAZtDhKFvfoWw==
Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id B75DF3127AF8
	for <gwml@vger.gnuweeb.org>; Fri,  1 Aug 2025 23:43:59 +0000 (UTC)
Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-879d2e419b9so1717134a12.2
        for <gwml@vger.gnuweeb.org>; Fri, 01 Aug 2025 16:43:59 -0700 (PDT)
X-Forwarded-Encrypted: i=1; AJvYcCUf/KhKSP5Rdoq7JSphAf/MeS2f6HsIJDCdN1cx1oapH6DiDfnuPQvLkbSL3rpL6icD98mn@vger.gnuweeb.org
X-Gm-Message-State: AOJu0Ywd4WA4OdfPrTYF0iljsuD3kpvwb4nI3EL/eZhss/gw9tbmKny4
	FkNlLKXAIdHV1ZrnzdCHsCNT4KryCFKBwE6cxOOtsi5IZYc+TSpIEUX5/Ee+MrSquTyoXaTs148
	/7Hxl4BZZOw+pPuqfXfqIO/8N8LQDIFw=
X-Google-Smtp-Source: AGHT+IFRJBL6ANeudanDT761KX7vndNYp3j/5wN31Bbw+7geXKtGwuISaJ2T+4E95+L0/IB1sRyNevksEEye48AbgsA=
X-Received: by 2002:a17:90b:4b8a:b0:31f:32c0:9da9 with SMTP id
 98e67ed59e1d1-321161dd624mr2056598a91.6.1754091838121; Fri, 01 Aug 2025
 16:43:58 -0700 (PDT)
MIME-Version: 1.0
References: <20250801015427.439511-1-reyuki@gnuweeb.org> <20250801015427.439511-2-reyuki@gnuweeb.org>
In-Reply-To: <20250801015427.439511-2-reyuki@gnuweeb.org>
From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Date: Sat, 2 Aug 2025 06:43:47 +0700
X-Gmail-Original-Message-ID: <CAOG64qN95Voxe5yu8ppb2N=s7Hs2UbE_Yg8Q4ARjod9Cuka0Lw@mail.gmail.com>
X-Gm-Features: Ac12FXzRkjEolmRDR62w4NK06sziuBNvZ9aB7AeC5MEYOrQ2jJifstc-xvArgiM
Message-ID: <CAOG64qN95Voxe5yu8ppb2N=s7Hs2UbE_Yg8Q4ARjod9Cuka0Lw@mail.gmail.com>
Subject: Re: [PATCH gwproxy v2 1/3] dnslookup: split common functionality and
 struct into net.c
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>, "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <gwml.vger.gnuweeb.org>

On Fri, Aug 1, 2025 at 8:55=E2=80=AFAM Ahmad Gani wrote:
> +__cold
> +int convert_str_to_ssaddr(const char *str, struct gwp_sockaddr *gs, uint=
16_t prt)

(( Nit: Change the var name from prt to port. The naming prt sounds weird. =
))

That port parameter addition should not be separate. So this should be
broken down into two commits:

   - Move convert_ssaddr_to_str to net.c.
   - Add a new parameter, default_port.

Also, you need to explain the reason why the port parameter is needed
in the commit message. For now, I don't see any explanation in this
patch why the port parameter is needed.

-- Viro