Re: [PATCH v1 00/26] The complete version of the Discord bot

[Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>]

On Tue, Oct 4, 2022 at 6:18 AM Muhammad Rizki wrote:
> On 04/10/2022 06.12, Alviro Iskandar Setiawan wrote:
>> On Mon, Oct 3, 2022 at 7:48 PM Ammar Faizi wrote:
>>> Files are not deleted:
>>>
>>> ammarfaizi2@integral2:~/app/lore-daemon.dev/daemon$ ls dscord/storage -l
>>> total 0
>>> drwxrwxr-x 1 ammarfaizi2 ammarfaizi2  78 Sep  3 17:25 23035eeb480f2b3501ba0841ef10ce3f
>>> drwxrwxr-x 1 ammarfaizi2 ammarfaizi2  12 Oct  3 19:42 6766c45fa800d71173893158b2c7d640
>>> drwxrwxr-x 1 ammarfaizi2 ammarfaizi2   0 Sep  3 17:22 78380c23529749c280e4cca46f7519c9
>>> drwxrwxr-x 1 ammarfaizi2 ammarfaizi2   0 Sep  3 17:23 a23e986acc2c75d08a3e98377f06bbfe
>>> drwxrwxr-x 1 ammarfaizi2 ammarfaizi2 356 Sep  3 17:22 b241bd7c932c70e6a81d107da019cb67
>>> drwxrwxr-x 1 ammarfaizi2 ammarfaizi2  12 Sep  3 17:25 bcaac8364eaf04951d504faa1f1df826
>>> drwxrwxr-x 1 ammarfaizi2 ammarfaizi2   0 Sep  3 17:23 c36cdede05b536d395c5b55dbae92288
>>> ammarfaizi2@integral2:~/app/lore-daemon.dev/daemon$
>>
>> bang, only 1 file from 3rd Oct, the rest are all old files from a
>> month ago, look at the date
>>
>
> Yes, this issue has already been a long time not fixed, because, in the
> past, I still don't know what caused it. Now, I think I see the problem.
> I've patched it and tested it. Wait until I send new PATCH email, thanks.

the error Ammar reported could be the reason why the files are not
deleted, because if you hit an error, the code next to it won't be
executed, for ex:

aaa() # error here
bbb() # this doesn't get executed

you must use finally to handle this:

try:
    aaa() # error here
execpt:
    pass
finally:
    bbb() # it always gets executed

but idk, i didn't investigate, just speculate

-- Viro