From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1754462467; bh=AC2aMudeh1r1PI3NaV2sin6K/rxqc24pZ0oAd50XqXU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=JRAdWVGIyS5qTi607cZiQ6W1737u5rOvaip4QE9C8KkpDAGGlYeiYNc8peNjzq54u Jnhc+lTMz9YRIqphP0z0p4sdWg7baoASIy6CvVlNOfznOMHENHbhVEBRg1Fbqi8+KB 5h2CNK1yd67tCvjLwpbgAyz2Rm6L04At9O+o33j31KTJE42O/3WgPzoy2giEWx1wY7 GFKQrcQMYcibvJu2sn+8VXXwl0TIhnbLEWsnxTQFMjAPVm00Eus7U9m2A06LFL6ZgH NXICGeWM3sQKeb5ytFNbfJ3mAN1DzaJ5Fkt983AuYLwZH4VAFhuaj694ElU7z9dL+p 09Qx5WKqAXlqg== Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 9359F3127C3E for ; Wed, 6 Aug 2025 06:41:07 +0000 (UTC) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-76bed310fa1so3194557b3a.2 for ; Tue, 05 Aug 2025 23:41:07 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXt7DDvGx+FPjyf5xhcX77AoX3sEQMc+UPFpsgJFfUvkd7Qpx9KnalALW6LL7K6CbFRVStk@vger.gnuweeb.org X-Gm-Message-State: AOJu0YySDeuqRgUKoUKSGPIilSoJ6OkHNlFblig0Jp7KcztlHE/EbYb2 7mYC60QI3XEwh++AvTELkxX3pAM5QMtYtnXlVl00AmgOMj7vmPRqv1q/D7V13N7uC+/4McyrcZo zpyywLW8BJqIyPmK0vIOei9x8XoQGpVw= X-Google-Smtp-Source: AGHT+IEQk93J//qFAlERjDJ/Qu9VrZzgGahlcvpCpMP0OD0YWNgT4q8Gkr2UNTJuThjXCWzwg8vDtaSkjJTku9T1y+8= X-Received: by 2002:a05:6a20:9392:b0:240:203d:42a with SMTP id adf61e73a8af0-240330c2bafmr2039454637.21.1754462465907; Tue, 05 Aug 2025 23:41:05 -0700 (PDT) MIME-Version: 1.0 References: <20250806035727.216702-1-reyuki@gnuweeb.org> <20250806035727.216702-5-reyuki@gnuweeb.org> In-Reply-To: <20250806035727.216702-5-reyuki@gnuweeb.org> From: Alviro Iskandar Setiawan Date: Wed, 6 Aug 2025 13:40:54 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXyDSiPu7mTRfXIQQmdQvJ0MzCbKH9x09o2rCL9eKeulvegtsG6W2lEzmag Message-ID: Subject: Re: [PATCH gwproxy v4 4/6] dnslookup: Initial work for implementation of C-ares-like getaddrinfo function To: Ahmad Gani Cc: Ammar Faizi , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Wed, Aug 6, 2025 at 10:57=E2=80=AFAM Ahmad Gani wrote: > +int gw_ares_init(gw_ares_channel_t **channel, struct gw_ares_options *op= ts) > +{ > + gw_ares_channel_t *c; > + int ret; > + > + if (!opts->nr_server) > + return -EINVAL; > + > + c =3D malloc(sizeof(*c)); > + if (!c) > + return -ENOMEM; > + > + *channel =3D c; > + c->nr_server =3D opts->nr_server; > + c->servers =3D malloc(c->nr_server * sizeof(*c->servers)); > + if (!c->servers) { > + free(c); > + return -ENOMEM; > + } > + /* > + * TODO(reyuki): validate flags and > + * for now use it to control recursion desired (RD) bit? > + */ > + c->flags =3D opts->flags; > + for (int i =3D 0; i < c->nr_server; i++) { > + ret =3D convert_str_to_ssaddr(opts->servers[i], &c->serve= rs[i], DEFAULT_DOMAIN_PORT); > + if (ret) { > + free(c->servers); > + free(c); > + return ret; > + } > + } > + > + return 0; > +} Again, I don't see any point in filling `*channel` with a dangling pointer on error. This part "*channel =3D c", can't you do that only when successful? Please address the previous review properly. Don't ignore comments. -- Viro