From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alviro.iskandar@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED
	autolearn=no autolearn_force=no version=3.4.6
Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52])
	by gnuweeb.org (Postfix) with ESMTPSA id E52AC80C18
	for <gwml@vger.gnuweeb.org>; Fri,  2 Sep 2022 06:07:22 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1662098842;
	bh=PiaEYF9V4R1/VV1YtAFSzk79pFqLN+y5TIiv+FSE56s=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=OoAJci5hvqoDqyYu/UXBtEWbLW5/Na2KZtluYMjz4L/JffyoBncRneQ4F6NK2jOkJ
	 FXE+kwbN8hf6N1lA8mzs2Ash6nliUmWF8aiSv6267MayJD6aq+Y8DFesb4VQ4RnUoj
	 4sHReti68b73zzPAh/U1hdkmDubgFXwYZQ7pIL9ZvxhFeAtpi6u+Kt55Bio5oGEawj
	 6AXXdSTjmABShneA9pFE4cYGF6NNVn+qY9Sr30OcnRU8pEF9s5Bw+yWkYuUkYboFUM
	 lD4V/pzKRYXoezqGlXlqgaj7snIYNQwgauxnCAuOKYilA264SGL1+31yRqJ94ujBbI
	 dVD59ObArj2ew==
Received: by mail-lf1-f52.google.com with SMTP id p16so1828256lfd.6
        for <gwml@vger.gnuweeb.org>; Thu, 01 Sep 2022 23:07:22 -0700 (PDT)
X-Gm-Message-State: ACgBeo3YLbJ4pymsnqyuNkuwBpFkU5LaluQ94RpBxt4q3nDANgAnzZKO
	DviBc9uElBJjRvUJFhcfCyevJjZR+ajXQ4XRf/g=
X-Google-Smtp-Source: AA6agR7zqAsNA+aX2F4bX+1NP6kq6bzXPrNhUcfyFtj/mY5Hk6EztOTtUT+BnxMoMJgMUdv+WSSOFuldDEcqwbEogxY=
X-Received: by 2002:ac2:544d:0:b0:494:7842:23c6 with SMTP id
 d13-20020ac2544d000000b00494784223c6mr5630346lfn.641.1662098841108; Thu, 01
 Sep 2022 23:07:21 -0700 (PDT)
MIME-Version: 1.0
References: <20220902011548.2506938-1-ammar.faizi@intel.com> <20220902011548.2506938-4-ammar.faizi@intel.com>
In-Reply-To: <20220902011548.2506938-4-ammar.faizi@intel.com>
From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Date: Fri, 2 Sep 2022 13:07:09 +0700
X-Gmail-Original-Message-ID: <CAOG64qNRX7DwcJHX_VMTMODXygxZTc-ciKtM7rcFfNLvGD_Ujg@mail.gmail.com>
Message-ID: <CAOG64qNRX7DwcJHX_VMTMODXygxZTc-ciKtM7rcFfNLvGD_Ujg@mail.gmail.com>
Subject: Re: [RESEND PATCH liburing v1 03/12] t/socket-rw: Don't brute force
 the port number
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Jens Axboe <axboe@kernel.dk>, Dylan Yudaken <dylany@fb.com>, 
	Facebook Kernel Team <kernel-team@fb.com>, Pavel Begunkov <asml.silence@gmail.com>, 
	io-uring Mailing List <io-uring@vger.kernel.org>, "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>, 
	Kanna Scarlet <knscarlet@gnuweeb.org>, Muhammad Rizki <kiizuha@gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <gwml.vger.gnuweeb.org>

On Fri, Sep 2, 2022 at 8:18 AM Ammar Faizi wrote:
> From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
>
> Don't brute force the port number, use `t_bind_ephemeral_port()`,
> much simpler and reliable for choosing a port number that is not
> in use.
>
> Cc: Dylan Yudaken <dylany@fb.com>
> Cc: Facebook Kernel Team <kernel-team@fb.com>
> Cc: Pavel Begunkov <asml.silence@gmail.com>
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>

Reviewed-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>

tq

-- Viro