From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by gnuweeb.org (Postfix) with ESMTPSA id 3EEF27E30C for ; Mon, 14 Mar 2022 23:38:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1647301113; bh=wIqQvh6SBH7/sGVClwpwSqfcrSrcjWMeXd2Jqdos78Q=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=SF94SUvS8LJUWE9hy25eQlftDp0lAuo2+vUJFf3uWZwImg4PZ56TeTK8Whi3Zsgpq LTa5pm9Nvr3y3G2Jrm+dX1eECGorxNWssXdOHFOz24MntWpiStPDUsAM2jcgAdTYOr cXHw1zbaSVRzplfbBeEAexhMHYWkZh/UZ72NTFUZoZEXg0ltyb69VcMEHbhqLdWGrA CnSAFUkjCjnCGjuMKDSGj28/Mx8c7vH6DqSw8NMuygo68kDCEd5WhJK+CB+YHrfeLA DXosJw4uhLGQLrlg4AbIaVREjYJf5GUhkCTQtW32bHTRdLd3DKJl/cFh2RJ3AqE376 A2OdCZWmaUo4g== Received: by mail-lf1-f48.google.com with SMTP id w7so30037342lfd.6 for ; Mon, 14 Mar 2022 16:38:33 -0700 (PDT) X-Gm-Message-State: AOAM530LrrtCkYwdEyXVKn13+2WPf+skEzpFfUmBGiCcNT2FrIXJl0hZ t7jBF9sqdgCaQGjSNhz/JdUDsW8KkFUW56hn4/c= X-Google-Smtp-Source: ABdhPJzjbTe0C+EB0JCEH8nKklBaChHKoWAjB6pm0Yx3tVZK6ZlpNE/YAxy/WZLl0PWZHm/FmYeIcj6s+9bIXMcWQJw= X-Received: by 2002:a05:6512:3f90:b0:446:6b95:24aa with SMTP id x16-20020a0565123f9000b004466b9524aamr15278707lfa.610.1647301111209; Mon, 14 Mar 2022 16:38:31 -0700 (PDT) MIME-Version: 1.0 References: <202203091430.MLY27Bif-lkp@intel.com> <20220309065849.96165-1-alviro.iskandar@gnuweeb.org> In-Reply-To: From: Alviro Iskandar Setiawan Date: Tue, 15 Mar 2022 06:38:19 +0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning To: Nathan Chancellor Cc: Mark Brown , Codrin Ciubotariu , Nugraha , llvm@lists.linux.dev, kbuild-all@lists.01.org, "GNU/Weeb Mailing List" , Linux Kernel Mailing List , kernel test robot , Alviro Iskandar Setiawan Content-Type: text/plain; charset="UTF-8" List-Id: On Tue, Mar 15, 2022 at 5:07 AM Nathan Chancellor wrote: > Hi Alviro, [...] > > I would recommend removing these and just setting those values via git > send-email flags. In other words: > > git send-email --to "..." --cc "..." --cc "..." > > and so on. It can cause a lot of spam if this patch is ever backported > or needed in other trees. Fixed. > > Reported-by: kernel test robot > > Link: https://lore.kernel.org/lkml/202203091430.MLY27Bif-lkp@intel.com > > Fixes: 50291652af5269813baa6024eb0e81b5f0bbb451 ("ASoC: atmel: mchp-pdmc: add PDMC driver") > > This should be simplified to: > > Fixes: 50291652af52 ("ASoC: atmel: mchp-pdmc: add PDMC driver") > > I don't think the automated checkers will complain about that but the > short form is preferred. Fixed. > > Signed-off-by: Alviro Iskandar Setiawan > > Thanks a lot for the patch! > > Reviewed-by: Nathan Chancellor > > I don't know if those nits are worth resending but I do not see this > applied to Mark's tree yet. It might have gotten lost because this was > sent as a reply to the build report, rather than its own thread, which > has caused issues for me in the past: > > https://lore.kernel.org/r/20210903162639.GM4932@sirena.org.uk/ > > If there is no action on this patch in the next couple of days, please > consider resending with the above nits addressed with Codrin's tag and > my tag. Will address those. Thanks for the review. -- Viro