Re: [PATCH gwproxy v4 5/6] dnsparser: Transaction id creation is delegated to caller

[Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>]

On Wed, Aug 6, 2025 at 10:57 AM Ahmad Gani wrote:
> --- a/src/gwproxy/dnsparser.c
> +++ b/src/gwproxy/dnsparser.c
> @@ -65,9 +65,9 @@ static ssize_t calculate_question_len(uint8_t *in, size_t in_len)
>
>  int serialize_answ(uint16_t txid, uint8_t *in, size_t in_len, gwdns_answ_data *out)
>  {
> -       size_t idx;
>         gwdns_header_pkt *hdr;
>         uint16_t raw_flags;
> +       size_t idx;
>         int ret;

Don't yield unrelated changes. Something like this, variable
reordering, should be squashed. It has no relevance with "Transaction
id creation is delegated to caller".

The subject should be changed too. Use imperative form.

-- Viro