From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1754461718; bh=ls5xKnReqg9Z3A8RZWdGWvL8JwgUFe50+/d1L/k0US0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=Tx2VBuRUuyjEr3e2ooJ2sxNDOM2EydzwZRCXw86uBolV9X6XdSk38rQHpUT4tc7lf UQ0gwa9JHZ0barMe7fjMWuaYwu43cVkDUucj/9tzyd8cj0XnUFzC4wsGaJ4KyPctjO XaX0UCG1Cp6EyS9jympj1FQ7BFXUQy38OrdDo6zCeaSKVx4B/p7jr1GLH+KaI4gEXQ LsJw42Iblsbg3XXke5LFYQ1l2b2Lgql9E6OX5veobSJaYhBzITtsIKsWbTKJJfShyF KP3HeDmqkebLfEDiDc1ZtN54cTqTpBgea6O318sltq42+56tSK3bX+q0OA/GjFBIpq 9GEu0qXswQlGQ== Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 6AD7D3127C3E for ; Wed, 6 Aug 2025 06:28:38 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-31ece02ad92so5162036a91.2 for ; Tue, 05 Aug 2025 23:28:38 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVyMyD0P3NUNdb4LsNzc4oVE5s0RClIyItxT258gRwgzO5G0BrCnsT8L0TLX0+T4Y/veWRB@vger.gnuweeb.org X-Gm-Message-State: AOJu0YwDXuZr4/nH965Sf8BB0n0X1/X9AV1aGyIt05C+yckNi3y0DFNL 3msWP2ZYRgGtmoYczUkWi3ZMhNgj+r5zVDdyYk8DuX1xlItaQkgti7tTRD+p5y21rLvbepsWHH6 /kiElY7Amst09x2DUgxXHUCEJ0sccbQ4= X-Google-Smtp-Source: AGHT+IFMPGmfp299Bjm7SXi0OvQGjsGKia+QgRH6qrJauK13zaRRGTpOmh0uJjcxY8sXPGGODbPbHaE2mubNp1UCajA= X-Received: by 2002:a17:90b:2d0d:b0:321:4765:a423 with SMTP id 98e67ed59e1d1-32166c167c6mr1970517a91.6.1754461716808; Tue, 05 Aug 2025 23:28:36 -0700 (PDT) MIME-Version: 1.0 References: <20250806035727.216702-1-reyuki@gnuweeb.org> <20250806035727.216702-6-reyuki@gnuweeb.org> In-Reply-To: <20250806035727.216702-6-reyuki@gnuweeb.org> From: Alviro Iskandar Setiawan Date: Wed, 6 Aug 2025 13:28:25 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXw4BXXr4-TcA9xKuVNZRsZxnNRYSNfGTSJ6L1K169OK_tdKM-2jAGG2yhk Message-ID: Subject: Re: [PATCH gwproxy v4 5/6] dnsparser: Transaction id creation is delegated to caller To: Ahmad Gani Cc: Ammar Faizi , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Wed, Aug 6, 2025 at 10:57=E2=80=AFAM Ahmad Gani wrote: > --- a/src/gwproxy/dnsparser.c > +++ b/src/gwproxy/dnsparser.c > @@ -65,9 +65,9 @@ static ssize_t calculate_question_len(uint8_t *in, size= _t in_len) > > int serialize_answ(uint16_t txid, uint8_t *in, size_t in_len, gwdns_answ= _data *out) > { > - size_t idx; > gwdns_header_pkt *hdr; > uint16_t raw_flags; > + size_t idx; > int ret; Don't yield unrelated changes. Something like this, variable reordering, should be squashed. It has no relevance with "Transaction id creation is delegated to caller". The subject should be changed too. Use imperative form. -- Viro