public inbox for [email protected]
 help / color / mirror / Atom feed
From: Alviro Iskandar Setiawan <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: "GNU/Weeb Mailing List" <[email protected]>,
	Muhammad Rizki <[email protected]>,
	 "M. Taufiq Hidayat Pohan" <[email protected]>
Subject: Re: [PATCH] helpers2: Change 'INNER JOIN' to 'LEFT JOIN'
Date: Sat, 1 Mar 2025 05:27:31 +0700	[thread overview]
Message-ID: <CAOG64qNdQ_E3NdfAwWsvJWjkMZThWafFEeMWQ9+==Hg8z0T_Nw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>

On Sat, Mar 1, 2025 at 5:25 AM Ammar Faizi wrote:
> Taufiq reported that he was unable to login via the new interface.
>
> After some debugging, it turned out the login query was returning an
> empty result-set because Taufiq did not have an entry in the
> "user_info" table and the query was using an "INNER JOIN" to fetch the
> user's information.
>
> Let's just fill the missing entry with NULL values by using
> "LEFT JOIN".
>
> If the user changes his/her information, the entry will be updated
> accordingly.
>
> Reported-by: M. Taufiq Hidayat Pohan <[email protected]>
> Signed-off-by: Ammar Faizi <[email protected]>

lmao, major QA failure

Reviewed-by: Alviro Iskandar Setiawan <[email protected]>

-- Viro

      reply	other threads:[~2025-02-28 22:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-28 22:24 [PATCH] helpers2: Change 'INNER JOIN' to 'LEFT JOIN' Ammar Faizi
2025-02-28 22:27 ` Alviro Iskandar Setiawan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOG64qNdQ_E3NdfAwWsvJWjkMZThWafFEeMWQ9+==Hg8z0T_Nw@mail.gmail.com' \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox