From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1740781664; bh=NDnc6JVt78iy4o0DzYK/4s21K4Q7E+1DH/kyEWPGMBw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=G75ih2esUzK8sKRbTN4LTPffXoy+WYqytbkx9RGnfBRpErxDM2wTxWMRuhafqelSu VopuNvAw+A6O7wuskTp2FqQti9MwLBFPtmLieThK1+7yEm2anPnAt0f3kmqFNRdkz2 LzuY6WG5iQ5pymo77STv/YfOPEF4xeZwtto/PlsocWE4r5Y6oX/Ywd4kBr4fcAWJ1N nXmhBGRmktYhDvIQrHKJLGVDS6sgkPTs6jboBdh9H9biOwHBpSptgArfOUvytYK91T h1mjcQCi9x7Rfe6rEiBoXoVuhpWZdCMDQXHv84FyTom/TmRE2w+zG7W6LggVk8U+CT AThaA2xRK1TiA== Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id A62572071A2C for ; Fri, 28 Feb 2025 22:27:44 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2fe96dd93b4so5425937a91.0 for ; Fri, 28 Feb 2025 14:27:44 -0800 (PST) X-Gm-Message-State: AOJu0YyPEvuTtQZuqo+c1+f6E99XqO7jiS8+C+to/hRKhBL9DqC/tXyx BwrbhKyOCf8NRQP27nKhLkzxHylb3NA4Ki2DesWOxw0luzgC668MEQ2saP3BSqkrTVCiOagUyec PezTV2jDIHWiZDxmm5CwUshUiN0Y= X-Google-Smtp-Source: AGHT+IHK5v1HMUEr7OFGl8UyeeUDIrzdHM/4HyQun34iFrqyXpw1k1tLxCv1/egXHJSyYeu4MJIByNjoyabwWmABPsM= X-Received: by 2002:a17:90b:2247:b0:2ee:ee77:226d with SMTP id 98e67ed59e1d1-2feba5cecd5mr8467593a91.4.1740781663083; Fri, 28 Feb 2025 14:27:43 -0800 (PST) MIME-Version: 1.0 References: <20250228222450.1587857-1-ammarfaizi2@gnuweeb.org> In-Reply-To: <20250228222450.1587857-1-ammarfaizi2@gnuweeb.org> From: Alviro Iskandar Setiawan Date: Sat, 1 Mar 2025 05:27:31 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: AQ5f1JrVXGuL-eL_3kbzMGx5IIZ6TjA6U5tXxxqDX8HHGD4QYykMgeDnAcfAd6I Message-ID: Subject: Re: [PATCH] helpers2: Change 'INNER JOIN' to 'LEFT JOIN' To: Ammar Faizi Cc: "GNU/Weeb Mailing List" , Muhammad Rizki , "M. Taufiq Hidayat Pohan" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Sat, Mar 1, 2025 at 5:25=E2=80=AFAM Ammar Faizi wrote: > Taufiq reported that he was unable to login via the new interface. > > After some debugging, it turned out the login query was returning an > empty result-set because Taufiq did not have an entry in the > "user_info" table and the query was using an "INNER JOIN" to fetch the > user's information. > > Let's just fill the missing entry with NULL values by using > "LEFT JOIN". > > If the user changes his/her information, the entry will be updated > accordingly. > > Reported-by: M. Taufiq Hidayat Pohan > Signed-off-by: Ammar Faizi lmao, major QA failure Reviewed-by: Alviro Iskandar Setiawan -- Viro