From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Ahmad Gani <reyuki@gnuweeb.org>,
"GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v11 4/6] gwproxy: Refactor code base to add experimental raw DNS backend
Date: Sun, 14 Sep 2025 20:54:09 +0700 [thread overview]
Message-ID: <CAOG64qNgZ_oa-VLOS6kFNF6w6fQ8HLt464Mx8JQCAGJfPgXkeQ@mail.gmail.com> (raw)
In-Reply-To: <20250914121417.GB31788-ammarfaizi2@gnuweeb.org>
On Sun, Sep 14, 2025 at 7:14 PM Ammar Faizi wrote:
> "Code refactoring" MUST NOT add a new feature.
That's right. Google "code refactoring meaning":
"Code refactoring is the process of restructuring existing source
code without changing its external functionality to improve its
internal structure, readability, and maintainability"
Ahmad Gani clearly doesn't understand what code refactoring means.
next prev parent reply other threads:[~2025-09-14 13:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-14 5:09 [PATCH gwproxy v11 0/6] Initial work on integration of DNS parser lib in gwproxy Ahmad Gani
2025-09-14 5:09 ` [PATCH gwproxy v11 1/6] dns: Use __sys_close instead of close Ahmad Gani
2025-09-14 5:09 ` [PATCH gwproxy v11 2/6] gwproxy: Define __maybe_unused macro Ahmad Gani
2025-09-14 5:09 ` [PATCH gwproxy v11 3/6] dnsparser: Add dns parser code Ahmad Gani
2025-09-14 5:09 ` [PATCH gwproxy v11 4/6] gwproxy: Refactor code base to add experimental raw DNS backend Ahmad Gani
2025-09-14 12:14 ` Ammar Faizi
2025-09-14 13:54 ` Alviro Iskandar Setiawan [this message]
2025-09-14 17:46 ` Ahmad Gani
2025-09-14 5:09 ` [PATCH gwproxy v11 5/6] gwproxy: Update Makefile and configure scripts Ahmad Gani
2025-09-14 12:55 ` Ammar Faizi
2025-09-14 17:45 ` Ahmad Gani
2025-09-14 5:09 ` [PATCH gwproxy v11 6/6] gwproxy: Reduce #ifdef CONFIG_RAW_DNS Ahmad Gani
2025-09-14 12:16 ` Ammar Faizi
2025-09-14 14:26 ` Alviro Iskandar Setiawan
2025-09-14 17:45 ` Ahmad Gani
2025-09-14 17:59 ` Alviro Iskandar Setiawan
2025-09-14 18:13 ` Ahmad Gani
2025-09-15 2:21 ` Alviro Iskandar Setiawan
2025-09-14 17:44 ` Ahmad Gani
2025-09-14 19:02 ` Ammar Faizi
2025-09-15 2:50 ` Alviro Iskandar Setiawan
2025-09-14 12:51 ` (subset) [PATCH gwproxy v11 0/6] Initial work on integration of DNS parser lib in gwproxy Ammar Faizi
2025-09-14 17:22 ` Alviro Iskandar Setiawan
2025-09-14 18:07 ` Ahmad Gani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOG64qNgZ_oa-VLOS6kFNF6w6fQ8HLt464Mx8JQCAGJfPgXkeQ@mail.gmail.com \
--to=alviro.iskandar@gnuweeb.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
--cc=reyuki@gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox