Re: [RFC PATCH v1 1/1] db: Create starting DDL for saving transaction

[Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>]

On Tue, Jun 28, 2022 at 2:27 PM Ammar Faizi wrote:
> Hi Al,
>
> On 6/28/22 1:21 PM, Alviro Iskandar Setiawan wrote:
> > +CREATE TABLE `transactions` (
> > +  `id` bigint unsigned NOT NULL AUTO_INCREMENT,
> > +  `trx_id` binary(20) NOT NULL,
> > +  `parent_trx_id` binary(20) NOT NULL,
>
> My worry on this is: you reference a parent transaction ID with the
> sha1 hash, there is no backup if that gets changed. What about using
> the sequence ID to reference it?

That should never change, if it ever gets changed, something has gone
very wrong.

> > +  `committer` varchar(255) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_520_ci NOT NULL,
> > +  `amount` bigint unsigned NOT NULL,
> > +  `notes` text COLLATE utf8mb4_unicode_520_ci NOT NULL,
> > +  `created_at` datetime NOT NULL,
> > +  PRIMARY KEY (`id`),
> > +  KEY `committer` (`committer`),
> > +  KEY `amount` (`amount`),
> > +  KEY `created_at` (`created_at`),
> > +  KEY `trx_id` (`trx_id`),
> > +  KEY `parent_trx_id` (`parent_trx_id`),
>
> As per my comment above, this can be a foreign key to the same
> table, to the PK id. Yes? No? Comment?

Sup.

tq

-- Viro