public inbox for [email protected]
 help / color / mirror / Atom feed
From: Alviro Iskandar Setiawan <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: Hazmi Alfarizqi <[email protected]>,
	"GNU/Weeb Mailing List" <[email protected]>,
	 Hazmi Alfarizqi <[email protected]>
Subject: Re: [PATCH server-a001 v2 3/4] Create `storage` directory for saving persistent data
Date: Sun, 1 May 2022 00:30:06 +0700	[thread overview]
Message-ID: <CAOG64qO7XsVqHCmeq4_CczZua-DqHqiPwbTSVZYFRnOEvsuz=A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>

On Sun, May 1, 2022 at 12:08 AM Ammar Faizi <[email protected]> wrote:
> This is a directory to save persistent data across `docker run`. All
> files inside this directory are ignored by git. They shouldn't be
> commited to the git tree. The first use case of this directory is for
> the MySQL database. The container will mount particular directories
> inside this `storage` directory.
>
> Side note: For data backup, the data inside the `storage` directory
> should be backed up by another method. Not by commiting the files to
> the git tree together with `server-a001` tree.
>
> Signed-off-by: Ammar Faizi <[email protected]>

You made typos:

  s/commited/committed
  s/commiting/committing

Also, public-inbox is a git tree too, so the former sentence is wrong.
But I understand the point of this patch. With those fixed, please
take:

Reviewed-by: Alviro Iskandar Setiawan <[email protected]>

tq

-- Viro

  reply	other threads:[~2022-04-30 17:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-30 17:08 [PATCH server-a001 v2 0/4] Install net-tools and MySQL server Ammar Faizi
2022-04-30 17:08 ` [PATCH server-a001 v2 1/4] Install net-tools Ammar Faizi
2022-04-30 17:08 ` [PATCH server-a001 v2 2/4] Install MySQL server Ammar Faizi
2022-04-30 17:24   ` Alviro Iskandar Setiawan
2022-04-30 17:08 ` [PATCH server-a001 v2 3/4] Create `storage` directory for saving persistent data Ammar Faizi
2022-04-30 17:30   ` Alviro Iskandar Setiawan [this message]
2022-04-30 17:39     ` Ammar Faizi
2022-04-30 17:54       ` Ammar Faizi
2022-05-01 12:13   ` Hazmi Alfarizqi
2022-04-30 17:08 ` [PATCH server-a001 v2 4/4] Create start.sh to start the docker container Ammar Faizi
2022-04-30 17:32   ` Alviro Iskandar Setiawan
2022-05-01 12:15   ` Hazmi Alfarizqi
2022-05-01 13:45     ` Ammar Faizi
2022-05-01 15:09       ` Hazmi Alfarizqi
2022-05-01 15:13         ` Ammar Faizi
2022-04-30 17:10 ` [PATCH server-a001 v2 0/4] Install net-tools and MySQL server Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOG64qO7XsVqHCmeq4_CczZua-DqHqiPwbTSVZYFRnOEvsuz=A@mail.gmail.com' \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox