From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by gnuweeb.org (Postfix) with ESMTPSA id D77737E7C6 for ; Sat, 30 Apr 2022 17:30:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1651339818; bh=OZ+Sm6NfhW5WsHdPgzSJCcVCZ3ssF+yS1332M2ihy8Q=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IyT40z/e3N88V8Gox6zyb8phwgsAYeF+FiYUowMH7gmyv7UBBEdksHZezO+bUePqa 4n3TPZkt/mxuwK6rDMl3DQVkdyEu9ouY9EAqXGIsouszAsZQsinYzvo2aPL8r5E3M7 prdnxv18sp9siDr1Aq1Vb6BhJbc2Oc84TFA/UWCtvxmQF/R7U9J8QHJsayK0u6r3MY OkeHvZuHwFWL7MgxoK7S7OHRHoNR3/RjMmG0Ka/pbI9ySe6jtz6MZPpYXh8htRM4H3 q1NcwtikEffN3Hm3U+A6/Ih+k4bIKZwwkV5JUnhtIu1w9Uh/0ePInIujldqjDU2PJ3 3JYonQy2i/Fjg== Received: by mail-lf1-f44.google.com with SMTP id w19so18986401lfu.11 for ; Sat, 30 Apr 2022 10:30:18 -0700 (PDT) X-Gm-Message-State: AOAM531Y0drx5N7eUlWOnL9ayOTfbQnYpwE0HTyTPgJKjA+YLj7cV/co wNivwJt4phHUCEyyM9mAiD2lFsIiwtTvGDD2RsM= X-Google-Smtp-Source: ABdhPJyXWkEmy9rMyQ7CQWOeIRFKhOG+rBYQLsS/uN98JAwjqLlFbF9xnZ95wgK0a2L6q1pincpTr1HKVpG04vzP+Z4= X-Received: by 2002:a05:6512:3a89:b0:472:311a:11cc with SMTP id q9-20020a0565123a8900b00472311a11ccmr3695210lfu.136.1651339817046; Sat, 30 Apr 2022 10:30:17 -0700 (PDT) MIME-Version: 1.0 References: <20220430170838.19571-1-ammarfaizi2@gnuweeb.org> <20220430170838.19571-4-ammarfaizi2@gnuweeb.org> In-Reply-To: <20220430170838.19571-4-ammarfaizi2@gnuweeb.org> From: Alviro Iskandar Setiawan Date: Sun, 1 May 2022 00:30:06 +0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH server-a001 v2 3/4] Create `storage` directory for saving persistent data To: Ammar Faizi Cc: Hazmi Alfarizqi , "GNU/Weeb Mailing List" , Hazmi Alfarizqi Content-Type: text/plain; charset="UTF-8" List-Id: On Sun, May 1, 2022 at 12:08 AM Ammar Faizi wrote: > This is a directory to save persistent data across `docker run`. All > files inside this directory are ignored by git. They shouldn't be > commited to the git tree. The first use case of this directory is for > the MySQL database. The container will mount particular directories > inside this `storage` directory. > > Side note: For data backup, the data inside the `storage` directory > should be backed up by another method. Not by commiting the files to > the git tree together with `server-a001` tree. > > Signed-off-by: Ammar Faizi You made typos: s/commited/committed s/commiting/committing Also, public-inbox is a git tree too, so the former sentence is wrong. But I understand the point of this patch. With those fixed, please take: Reviewed-by: Alviro Iskandar Setiawan tq -- Viro