Re: [PATCH gwproxy v5 2/2] dnsparser: Add dns parser code

[Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>]

On Fri, Aug 22, 2025 at 8:48 PM Alviro Iskandar Setiawan wrote:
> On Fri, Aug 22, 2025 at 12:44 PM Ahmad Gani wrote:
> > I just pushed a new branch at my github fork of gwproxy [1], you can take
> > a look if you want in the branch refactor-dns-feature.
>
> Nice, tq. I will take a look after the Jackson Hole speech.

(( The Jackson Hole's speech was very dovish, congrats if you went long ;-) ))

So, I have taken a look into your branch. And I saw commit
a02b58fe34ed ("dns: Remove code block related to the usage of glibc's
getaddrinfo_a function"). I am a little bit worried about that part.

My suggestion would be to create a new option in the configure file to
select what resolver type to be used. Let's mark this new feature as
experimental and keep the old feature for now. If your feature has
become stable enough, we can move forward abandoning getaddrinfo_a()
entirely.

Maybe './configure --use-raw-dns-resolver' or something else to enable
your experimental feature. If you go that way, don't forget to update
the GitHub CI to test your new feature.

What do you think?