From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1754463080; bh=F9hkgyS7cfAim5IX8W1McmkweaqSwgHgmEw1e6lyYz4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=n7tP9AA966IMLuxKvr7t1nH81KltWxgKeu8EHEUnJLga621FBHJyGYJsdvmdLOmSJ JLa38nXUla9LENMz235dlT2FQd8zg5O71FLzF9RJoQRK5TNETQquOVQaXRpt2C8JU5 6B6tKRK1528vueSQfvOqKIGOto+V5f1dUIPsAcTivAZ7H981XpckciGqD+OdMuYpi7 xw0EcIWhPeLWyK5YaJuzYYc2C+oKdzmJBOWt/CBICUCgeMkSpznSY4NwWNuTEDqGP5 pkpLy23PxG2V47wTqvIP7ey+AqnXqbCcNzDveoaE7FFycXpZtplUIZJgo+QpUvrZmg djMWOdRTwSINQ== Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id ED4CD3127C3D for ; Wed, 6 Aug 2025 06:51:19 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-32138e0d9adso2660405a91.2 for ; Tue, 05 Aug 2025 23:51:19 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUycpPTniVOBTfhdOaaX/2LkhsyHOO6xItaBDPQ7O2a7zOSfPAEGInu/ulcsP2U4ZrESH+j@vger.gnuweeb.org X-Gm-Message-State: AOJu0YzF+MXVS2zHh+ae4nxSKFkY6uL00KFX5WaHgQNbfs1HslH56ewK LuTSv/EELIfHvIuDyfNm8QtBitOZe7tnUHOLeLNw90l/UyuBETlrJLh/Fwp9Ptjluj9H6b3S80w 6103I8bIgag1AN82S0VlIxV/HZptxpWI= X-Google-Smtp-Source: AGHT+IHmEp8M4xOY/k9fkeoDGVUIbPR8xyv1fRbSZhWKA/gcachsGURdfxPv/UJ/bO0CyXLaY81xKbz0S8fcEVu+SDQ= X-Received: by 2002:a17:90b:2d0d:b0:321:4182:2b9e with SMTP id 98e67ed59e1d1-32166e09401mr2019683a91.12.1754463078254; Tue, 05 Aug 2025 23:51:18 -0700 (PDT) MIME-Version: 1.0 References: <20250806035727.216702-1-reyuki@gnuweeb.org> <20250806035727.216702-5-reyuki@gnuweeb.org> In-Reply-To: From: Alviro Iskandar Setiawan Date: Wed, 6 Aug 2025 13:51:07 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXwG0GtXsTEenBL6-MVWgC48mfYaLqq15FGqefBBUOyRjo1qUX4itOA_qm8 Message-ID: Subject: Re: [PATCH gwproxy v4 4/6] dnslookup: Initial work for implementation of C-ares-like getaddrinfo function To: Ahmad Gani Cc: Ammar Faizi , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Wed, Aug 6, 2025 at 1:40=E2=80=AFPM Alviro Iskandar Setiawan wrote: > On Wed, Aug 6, 2025 at 10:57=E2=80=AFAM Ahmad Gani wrote: > > +int gw_ares_init(gw_ares_channel_t **channel, struct gw_ares_options *= opts) > > +{ > > + gw_ares_channel_t *c; > > + int ret; > > + > > + if (!opts->nr_server) > > + return -EINVAL; > > + > > + c =3D malloc(sizeof(*c)); > > + if (!c) > > + return -ENOMEM; > > + > > + *channel =3D c; > > + c->nr_server =3D opts->nr_server; > > + c->servers =3D malloc(c->nr_server * sizeof(*c->servers)); > > + if (!c->servers) { > > + free(c); > > + return -ENOMEM; > > + } > > + /* > > + * TODO(reyuki): validate flags and > > + * for now use it to control recursion desired (RD) bit? > > + */ > > + c->flags =3D opts->flags; > > + for (int i =3D 0; i < c->nr_server; i++) { > > + ret =3D convert_str_to_ssaddr(opts->servers[i], &c->ser= vers[i], DEFAULT_DOMAIN_PORT); > > + if (ret) { > > + free(c->servers); > > + free(c); > > + return ret; > > + } > > + } > > + > > + return 0; > > +} > > Again, I don't see any point in filling `*channel` with a dangling > pointer on error. > > This part "*channel =3D c", can't you do that only when successful? > > Please address the previous review properly. Don't ignore comments. Also, the for loop needs a coding style fix. Don't declare the variable inside the for loop argument. Please stop repeating the same mistake again and again. DO NOT DO THIS: for (int i =3D 0; i < N; i++) { something; something; } DO THIS: int i; for (i =3D 0; i < N; i++) { something; something; } You should also incorporate other rules like placing variable declarations on the top (beginning of the scope). For example, I am still seeing this mistake: DO NOT DO THIS: void func(void) { func2(); func3(); int i; for (i =3D 0; i < N; i++) { func4(); func5(); } } DO THIS: void func(void) { int i; func2(); func3(); for (i =3D 0; i < N; i++) { func4(); func5(); } } How damn hard is it to understand? -- Viro