From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alviro.iskandar@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS,
	URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no
	version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1757498742;
	bh=VVRIkzjqaJdDD3jzzN8q9MsZAs/G2EzChwfC5GO/8iM=;
	h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
	 To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From:
	 Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date:
	 Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type:
	 Content-Transfer-Encoding;
	b=Z59KXXziZ+fGY8MWNkWc3TXz+bZPabfaJtCQHue5RuR6Sw36Fmlb4xRbtwfXS7o88
	 B1CIklTX8smlOhOMZY+k/ZapzgUD+q903xSFxAed4KqSiPhP6fU/lqKXrWPXf05+GM
	 ULlQoFOPggFP+RDfi7V3Zd9D/yFyptpZJ6Pe+Luiylnd+gcpxSB0swooqRYJqeYUXX
	 env2/mE502h0KtwA9y1ZChBQtt0HsvwVGyxiXO5AEX8b/CEAO/d1Ptr8zJS4Pd8md6
	 uu7+p7umNqAI6T51flaD0+VIEg5LkphnJYhsWogIgIbFoP/IEcOMHuc6i2Vo1qjiyZ
	 oop6mCj+f0jvw==
Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id B32AB31279D3
	for <gwml@vger.gnuweeb.org>; Wed, 10 Sep 2025 10:05:42 +0000 (UTC)
Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-329e47dfa3eso5783063a91.1
        for <gwml@vger.gnuweeb.org>; Wed, 10 Sep 2025 03:05:42 -0700 (PDT)
X-Forwarded-Encrypted: i=1; AJvYcCUzYlOi1Y2U6dQZy9QLADw2qQ7E5OfKJ0bdIy+LwAo9F9ipo0Fu6f1+QCkkOTopQl8hsYDA@vger.gnuweeb.org
X-Gm-Message-State: AOJu0Yw8vzrQxIzX6RAnXBC73t6ApPjMyFrvDz6r6+Af3bQIvSrZ2E1b
	wrc9g5taMkPXOY35lew88Wfu16pGx2bln+0u1B6JuUbRLDq3VBniQsOMWI6kKmd16BBrSKTTOdk
	DymoL8xF6Qk5ReNpS+jb0JkubGBZrHK4=
X-Google-Smtp-Source: AGHT+IFSM1GAZNkNpFBdG0AsuoWkKtOxEVTMuoj1JB9CaFWg2jCgKIyQYwbIU/rl53Z8NG35HIgS+ghbtHVcM6dwsV0=
X-Received: by 2002:a17:90b:4ec5:b0:32c:c40e:db0d with SMTP id
 98e67ed59e1d1-32d43f05062mr19881032a91.4.1757498741121; Wed, 10 Sep 2025
 03:05:41 -0700 (PDT)
MIME-Version: 1.0
References: <20250910030512.551673-1-reyuki@gnuweeb.org> <20250910030512.551673-3-reyuki@gnuweeb.org>
In-Reply-To: <20250910030512.551673-3-reyuki@gnuweeb.org>
From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Date: Wed, 10 Sep 2025 17:05:30 +0700
X-Gmail-Original-Message-ID: <CAOG64qOJ1pD5mM7GTy+sYcJqbjOt=vMdyOVvhGEXr3GjEj8arw@mail.gmail.com>
X-Gm-Features: Ac12FXxgD8XqicYgmKkx6bYWISuWTiHBgmoqVGsoJ7Ftw05MDs9vNrEhdd4m1gs
Message-ID: <CAOG64qOJ1pD5mM7GTy+sYcJqbjOt=vMdyOVvhGEXr3GjEj8arw@mail.gmail.com>
Subject: Re: [PATCH gwproxy v9 2/2] gwproxy: refactor code base to add
 experimental raw DNS backend
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>, "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <gwml.vger.gnuweeb.org>

On Wed, Sep 10, 2025 at 10:07=E2=80=AFAM Ahmad Gani wrote:
> +       cp =3D realloc(resolv->sess_map, sizeof(*cp) * newcap);
> +       if (!cp)
> +               return -ENOMEM;
> +
> +       stack =3D realloc(resolv->stack.arr, sizeof(*stack) * newcap);
> +       if (!stack) {
> +               free(cp);
> +               return -ENOMEM;
> +       }

The same realloc() issue here, I don't think you SHOULD call free(cp);
Instead ->sess_map needs to be set to "cp" independently because
->sess_map is still used afterwards.

--=20
Software Engineer & ITPM Officer
Alviro Iskandar Setiawan
+1 908 777 0074