From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alviro.iskandar@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS,
	URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no
	version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1754091923;
	bh=sx6/I6xouT3GJa43jFw4wGicEc6y1rLkDhiqYNe6PA8=;
	h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
	 To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From:
	 Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date:
	 Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type:
	 Content-Transfer-Encoding;
	b=nFWIFPYMJikkRcjxWI1qTRytd4nVPtC6BoqTTSM6yb3NjfCMS0ZEj9vG9x82tF2cJ
	 eNX+7kZ/Hdl2HSnBVcKvZ/V5Rlq/fx5zah7PHTQOlFpJR8tQ/isEACJhEvzHavkcSN
	 yc+j2Ow/5AF2pqgxlY5PnfaSptjrEM30nX1PQJ4yxhKLhqRjMBHM84dAzMkkPsuPl2
	 8lkpckjE8aVUOkxldBHjIZJGB/8QjXOQSkxa6/zvOpfxdSx//1PUoTxvEtoe4Af2jR
	 hDE/0VYQaLbcuX1j/YHnFYqc+XfRcnRrDoIOeodkSTqzlfABsrC6lyROh7/czu+Lfx
	 LRwQ71arE8BUA==
Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id D6F103127AF7
	for <gwml@vger.gnuweeb.org>; Fri,  1 Aug 2025 23:45:23 +0000 (UTC)
Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-b34a6d0c9a3so2457607a12.3
        for <gwml@vger.gnuweeb.org>; Fri, 01 Aug 2025 16:45:23 -0700 (PDT)
X-Forwarded-Encrypted: i=1; AJvYcCV68hqTBk0xn7/neGb+8Ik7Ncr8hoZkP97xyG6DkrYGZMnF4Ygh5OkflLPZP+bf5qFlACR2@vger.gnuweeb.org
X-Gm-Message-State: AOJu0Yw0RVuOJOXVG1PnW45m0NlLvie/7SnT5Sy/4i59WZDqg5V463ra
	+ZAmF1ecRT2LyqwL5TrBHQshVYCCaMPOo/V8u4fsVemMIUN48jcVVMPWnnAmkC7xchLUceKK5De
	emrdLKT7SVPv42L4dAlpUnS0lNdTxod0=
X-Google-Smtp-Source: AGHT+IFzIXqshkE/03/vAKiwz+sG5vhbuj5wYdTd1wzjdmysqCgU5yyoa6+8ZkDWdzaWhVu5SpCx4Gi2Owpix2IPGiw=
X-Received: by 2002:a17:90b:3b92:b0:321:1a89:f692 with SMTP id
 98e67ed59e1d1-3211a89f6b2mr343181a91.8.1754091922262; Fri, 01 Aug 2025
 16:45:22 -0700 (PDT)
MIME-Version: 1.0
References: <20250801015427.439511-1-reyuki@gnuweeb.org> <20250801015427.439511-2-reyuki@gnuweeb.org>
 <CAOG64qN95Voxe5yu8ppb2N=s7Hs2UbE_Yg8Q4ARjod9Cuka0Lw@mail.gmail.com>
In-Reply-To: <CAOG64qN95Voxe5yu8ppb2N=s7Hs2UbE_Yg8Q4ARjod9Cuka0Lw@mail.gmail.com>
From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Date: Sat, 2 Aug 2025 06:45:11 +0700
X-Gmail-Original-Message-ID: <CAOG64qOLbeX=YyYkHgi8R3o4rfb799z8h+c=Oo7Q7h1NagWMiA@mail.gmail.com>
X-Gm-Features: Ac12FXy96D1w6ytYV9IHZKDzNyh-FLBVk3_ZNYmbhnDotJstMrybqD28_MtFU-Q
Message-ID: <CAOG64qOLbeX=YyYkHgi8R3o4rfb799z8h+c=Oo7Q7h1NagWMiA@mail.gmail.com>
Subject: Re: [PATCH gwproxy v2 1/3] dnslookup: split common functionality and
 struct into net.c
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>, "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <gwml.vger.gnuweeb.org>

On Fri, Aug 1, 2025 at 8:55=E2=80=AFAM Ahmad Gani wrote:
> +__cold
> > +int convert_str_to_ssaddr(const char *str, struct gwp_sockaddr *gs, ui=
nt16_t prt)

(( RESEND: wrong sentence ))

(( Nit: Change the var name from prt to port. The naming prt sounds weird. =
))

That port parameter addition should be a separate patch. So this
should be broken down into two commits:

   - Move convert_ssaddr_to_str to net.c.
   - Add a new parameter, default_port.

Also, you need to explain the reason why the port parameter is needed
in the commit message. For now, I don't see any explanation in this
patch why the port parameter is needed.

-- Viro