From: Alviro Iskandar Setiawan <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: Jens Axboe <[email protected]>, Nugra <[email protected]>,
"GNU/Weeb Mailing List" <[email protected]>,
Tea Inside Mailing List <[email protected]>,
io-uring Mailing List <[email protected]>
Subject: Re: [PATCH liburing v1] queue, liburing.h: Avoid `io_uring_get_sqe()` code duplication
Date: Fri, 25 Feb 2022 07:46:36 +0700 [thread overview]
Message-ID: <CAOG64qORUFkWjO3e6paDrG9NhykTvd+RCfwFgjADHjxn+N2rSA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
On Fri, Feb 25, 2022 at 7:29 AM Ammar Faizi <[email protected]> wrote:
>
> Since commit 8be8af4afcb4909104c ("queue: provide io_uring_get_sqe()
> symbol again"), we have the same defintion of `io_uring_get_sqe()` in
Typo
/s/defintion/definition/
with that fixed
Reviewed-by: Alviro Iskandar Setiawan <[email protected]>
> queue.c and liburing.h.
>
> Make it simpler, maintain it in a single place, create a new static
> inline function wrapper with name `_io_uring_get_sqe()`. Then tail
> call both `io_uring_get_sqe()` functions to `_io_uring_get_sqe()`.
>
Also, I tested this, the fpos test failed. Maybe it needs the recent
kernel fixes? So I assume everything is fine.
Tests timed out: <rsrc_tags>
Tests failed: <fpos>
[viro@freezing ~/liburing]$ test/fpos
inconsistent reads, got 0s:8192 1s:6144
f_pos incorrect, expected 14336 have 7
failed read async=0 blocksize=7
Tested-by: Alviro Iskandar Setiawan <[email protected]>
-- Viro
next prev parent reply other threads:[~2022-02-25 0:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 0:28 [PATCH liburing v1] queue, liburing.h: Avoid `io_uring_get_sqe()` code duplication Ammar Faizi
2022-02-25 0:46 ` Alviro Iskandar Setiawan [this message]
2022-02-25 0:51 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOG64qORUFkWjO3e6paDrG9NhykTvd+RCfwFgjADHjxn+N2rSA@mail.gmail.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox