From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alviro.iskandar@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED
	autolearn=no autolearn_force=no version=3.4.6
Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53])
	by gnuweeb.org (Postfix) with ESMTPSA id EC09680CEB
	for <gwml@vger.gnuweeb.org>; Mon,  5 Sep 2022 08:43:07 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1662367387;
	bh=6J96x3mW8M3bkDSdhFwYDfhmT16/00u3mv7/kedunFc=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=bWM2itiLlVL3gO7oH0Ip4gj7ChBcUkxiZiSxOCCTTFryAA4+y+BYB+CVJ9MGDn06i
	 lAHvoTX2dKSjO0v9sORkhtFni1NFPI4eMKwu7S36PQj6rL7oJng2MuyObFSzONFDMw
	 ZW6zGnWNFIG1hO69CiTMb6tqqaKpSai4pbizzbn1EpoDRLCVi7YGUO/gNXDFIf0zx6
	 O+My5sm8UCUbXxs9SA93QB9QOTQv3dw/3ZJ2dnIWyZX0EN3P23DnhxaLZ+wvh52jdS
	 HEeuOKeEsRjlsApufAeHu+5tSjsj4hL9raR/9gAUtJkDBmL/mXhEG7NPSweLQ9bCe4
	 tzuiDMMJ907BQ==
Received: by mail-lf1-f53.google.com with SMTP id bq23so12113867lfb.7
        for <gwml@vger.gnuweeb.org>; Mon, 05 Sep 2022 01:43:07 -0700 (PDT)
X-Gm-Message-State: ACgBeo10dYOmOsFiQ3pzetykRS20PYP90x0bzGZBsBcmM1LCGgz3qbpI
	cu0FMiDzrPv5tFAjP3whqjRO1jvxXo2xHz8EEQU=
X-Google-Smtp-Source: AA6agR6SH5wlNLo07rYuPlJLs7Y7paovRou6JTU/UoJDNYmMO1lFfSBmTmtBBDM6xRhXq9Bq91v+lWj8cI7YdBg33pI=
X-Received: by 2002:ac2:544d:0:b0:494:7842:23c6 with SMTP id
 d13-20020ac2544d000000b00494784223c6mr10264001lfn.641.1662367386056; Mon, 05
 Sep 2022 01:43:06 -0700 (PDT)
MIME-Version: 1.0
References: <20220905070633.187725-1-ammar.faizi@intel.com>
In-Reply-To: <20220905070633.187725-1-ammar.faizi@intel.com>
From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Date: Mon, 5 Sep 2022 15:42:54 +0700
X-Gmail-Original-Message-ID: <CAOG64qOUeGV1ZY8-Lu01+X=a-sGkxgag7tx3g+pQ_gF8=BGjKQ@mail.gmail.com>
Message-ID: <CAOG64qOUeGV1ZY8-Lu01+X=a-sGkxgag7tx3g+pQ_gF8=BGjKQ@mail.gmail.com>
Subject: Re: [PATCH liburing v1] test/ringbuf-read: Delete `.ringbuf-read.%d`
 before exit
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Jens Axboe <axboe@kernel.dk>, Pavel Begunkov <asml.silence@gmail.com>, 
	io-uring Mailing List <io-uring@vger.kernel.org>, "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>, 
	Kanna Scarlet <knscarlet@gnuweeb.org>, Muhammad Rizki <kiizuha@gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <gwml.vger.gnuweeb.org>

On Mon, Sep 5, 2022 at 2:12 PM Ammar Faizi wrote:
>         fd = open(fname, O_WRONLY);
>         if (fd < 0) {
>                 perror("open");
> -               goto err;
> +               ret = 1;
> +               goto out;
>         }
>         for (i = 0; i < NR_BUFS; i++) {
>                 memset(buf, i + 1, BUF_SIZE);
>                 ret = write(fd, buf, BUF_SIZE);
>                 if (ret != BUF_SIZE) {
>                         fprintf(stderr, "bad file prep write\n");
> -                       goto err;
> +                       ret = 1;
> +                       close(fd);
> +                       goto out;
>                 }
>         }

should use T_EXIT_* for ret?

-- Viro