From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
"GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v8 2/2] gwproxy: refactor code base to add experimental raw DNS backend
Date: Sat, 6 Sep 2025 14:02:28 +0700 [thread overview]
Message-ID: <CAOG64qO_wO9v01OqzepUmsaHg1GKBtCA4wUNojOVAP5+0NE8wA@mail.gmail.com> (raw)
In-Reply-To: <CAADvAgrzp9DgDYXf=-nV=cG1H9Qzf1hnHPoksPGEKg88M_wK+g@mail.gmail.com>
On Sat, Sep 6, 2025 at 1:49 PM Ahmad Gani wrote:
> ./src/gwproxy/dns.h:112:20: error: invalid use of undefined type
> ‘struct gwp_dns_ctx’
> 112 | *addr = ctx->ns_addr;
> | ^~
> ./src/gwproxy/dns.h:113:23: error: invalid use of undefined type
> ‘struct gwp_dns_ctx’
> 113 | *addrlen = ctx->ns_addrlen;
My advice would be to expose that struct and kill cp_nsaddr() addr
entirely. That __sys_sendto() accepts "const struct sockaddr *"
anyway, so it won't change anything. No point in copying to local var.
next prev parent reply other threads:[~2025-09-06 7:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 7:55 [PATCH gwproxy v8 0/2] Initial work on integration of DNS parser lib in gwproxy Ahmad Gani
2025-08-29 7:55 ` [PATCH gwproxy v8 1/2] dnsparser: Add dns parser code Ahmad Gani
2025-08-29 7:55 ` [PATCH gwproxy v8 2/2] gwproxy: refactor code base to add experimental raw DNS backend Ahmad Gani
2025-09-05 16:26 ` Alviro Iskandar Setiawan
2025-09-06 4:32 ` Ahmad Gani
2025-09-06 5:16 ` Ahmad Gani
2025-09-06 6:17 ` Ahmad Gani
2025-09-06 6:48 ` Ahmad Gani
2025-09-06 7:02 ` Alviro Iskandar Setiawan [this message]
2025-09-06 6:47 ` Alviro Iskandar Setiawan
2025-09-09 2:38 ` reyuki
2025-09-06 11:27 ` Ahmad Gani
2025-09-06 12:01 ` Alviro Iskandar Setiawan
2025-09-06 12:58 ` Ahmad Gani
2025-09-06 13:30 ` Alviro Iskandar Setiawan
2025-09-06 13:44 ` Alviro Iskandar Setiawan
2025-09-06 14:26 ` Ahmad Gani
2025-09-06 14:30 ` Alviro Iskandar Setiawan
2025-09-07 4:22 ` Ammar Faizi
2025-09-07 5:57 ` Ammar Faizi
2025-09-07 6:39 ` Ahmad Gani
2025-09-07 6:40 ` Ahmad Gani
2025-09-07 6:43 ` Ammar Faizi
2025-09-07 7:06 ` Ammar Faizi
2025-09-07 7:17 ` Ahmad Gani
2025-09-07 9:52 ` Ahmad Gani
2025-09-07 10:19 ` Ammar Faizi
2025-09-07 10:36 ` Ahmad Gani
2025-09-06 7:14 ` Alviro Iskandar Setiawan
2025-09-06 7:21 ` Ahmad Gani
2025-09-06 7:47 ` Alviro Iskandar Setiawan
2025-09-06 11:01 ` Ahmad Gani
2025-09-05 9:18 ` [PATCH gwproxy v8 0/2] Initial work on integration of DNS parser lib in gwproxy Ammar Faizi
2025-09-05 9:34 ` Alviro Iskandar Setiawan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOG64qO_wO9v01OqzepUmsaHg1GKBtCA4wUNojOVAP5+0NE8wA@mail.gmail.com \
--to=alviro.iskandar@gnuweeb.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
--cc=reyuki@gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox