From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alviro.iskandar@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_ZEN_BLOCKED_OPENDNS
	autolearn=ham autolearn_force=no version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1757142161;
	bh=DrAgdX/CKGoOikDCmC8PzqJN3PzdrsP17xt63HXPyAM=;
	h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
	 To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From:
	 Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date:
	 Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type:
	 Content-Transfer-Encoding;
	b=hvs+aJkzeD8rGS4Y++oNXSvvdOpxilQAmlH5D2v37nn/c4PH9cxANmumLQrBIBwmY
	 feuEzPCS4PoAkvNelwtUbEsGPTFzJLqdmyt7hz7Oz223AVRgS0TD7wAv5A0t72pq6x
	 xZLbMJerPCwk8Gi3VwvFJ0ASLLfrm2ag/jwAxx5EGddjLsY7b4gYUXEc4DyZvCV8lf
	 QKuTnS4N2gMMxxZoO4wgOhhRk5PmEYql2giWBLZ/fYCB4T2LDG7KWdOl58AYojIpJ8
	 7KtYWH16TZv3uHYpQvlTRBHbAQyZ/d/d11N3M0j0Yjhpx9kGLsVr16/DonRZfkOu1K
	 a2qsmNqz7X28A==
Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id EE2DE3127AA3
	for <gwml@vger.gnuweeb.org>; Sat,  6 Sep 2025 07:02:40 +0000 (UTC)
Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7728a8862ccso2677107b3a.0
        for <gwml@vger.gnuweeb.org>; Sat, 06 Sep 2025 00:02:40 -0700 (PDT)
X-Forwarded-Encrypted: i=1; AJvYcCVZVqGqLEFIW+jeyaCl3G5UEUKnZ+vSfdsM8Tp3Wv3UwTTSHUa4nyjuohPpOEqM9OQUKBIi@vger.gnuweeb.org
X-Gm-Message-State: AOJu0YxrU/DuEvEilB96BNVxlkKTEOpl2wdiBeweE05ViO+ftgv/xAqi
	jODFKEpElB8SaUTMSFv/GFyZDWzlZ8vuNbBkMJzKAYmlpa40C5vIfYHc0AQjErFZ4Sy8FotTzkm
	CwHJHGDNTp2cEZyzMV3ZCmzqkFlkeRM8=
X-Google-Smtp-Source: AGHT+IFK+jhRV0GeS+UdQhVWrru8RmIprmiRMH5BAJSlghgvyEp1jthTtqEQSQHtGW9TV1vSnz8JtlWCY30nevkkFDk=
X-Received: by 2002:a05:6a20:7d9e:b0:24e:2cb:673b with SMTP id
 adf61e73a8af0-2537e066fcemr1464890637.26.1757142159313; Sat, 06 Sep 2025
 00:02:39 -0700 (PDT)
MIME-Version: 1.0
References: <20250829075557.598176-1-reyuki@gnuweeb.org> <20250829075557.598176-3-reyuki@gnuweeb.org>
 <CAOG64qN+BXH0S5YTzBrgY4JAJPd-TSDpiOd8YSirU=BA0hUy2Q@mail.gmail.com>
 <CAADvAgrjW-yAOoXU5RJpAsbLiZdHbjJHNJqeEM1gMxF3ZkseRA@mail.gmail.com>
 <CAADvAgo5OT0P-z3BEd8t20RvA_cRJ738LbCiTeUZ4YRt6xqBbg@mail.gmail.com> <CAADvAgrzp9DgDYXf=-nV=cG1H9Qzf1hnHPoksPGEKg88M_wK+g@mail.gmail.com>
In-Reply-To: <CAADvAgrzp9DgDYXf=-nV=cG1H9Qzf1hnHPoksPGEKg88M_wK+g@mail.gmail.com>
From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Date: Sat, 6 Sep 2025 14:02:28 +0700
X-Gmail-Original-Message-ID: <CAOG64qO_wO9v01OqzepUmsaHg1GKBtCA4wUNojOVAP5+0NE8wA@mail.gmail.com>
X-Gm-Features: Ac12FXz9PjtcqTwrIiqniR1Ek5OyFrGGpBZO3hDgSGTU6HogJ8tcGYdGDk2dZVU
Message-ID: <CAOG64qO_wO9v01OqzepUmsaHg1GKBtCA4wUNojOVAP5+0NE8wA@mail.gmail.com>
Subject: Re: [PATCH gwproxy v8 2/2] gwproxy: refactor code base to add
 experimental raw DNS backend
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>, "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <gwml.vger.gnuweeb.org>

On Sat, Sep 6, 2025 at 1:49=E2=80=AFPM Ahmad Gani wrote:
> ./src/gwproxy/dns.h:112:20: error: invalid use of undefined type
> =E2=80=98struct gwp_dns_ctx=E2=80=99
> 112 | *addr =3D ctx->ns_addr;
> | ^~
> ./src/gwproxy/dns.h:113:23: error: invalid use of undefined type
> =E2=80=98struct gwp_dns_ctx=E2=80=99
> 113 | *addrlen =3D ctx->ns_addrlen;

My advice would be to expose that struct and kill cp_nsaddr() addr
entirely. That __sys_sendto() accepts "const struct sockaddr *"
anyway, so it won't change anything. No point in copying to local var.