Re: [PATCH server-a001 v1 2/2] Install MySQL server

[Alviro Iskandar Setiawan <alviro.iskandar@gmail.com>]

On Sun, Apr 17, 2022 at 9:03 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
> On 4/17/22 8:52 PM, Alviro Iskandar Setiawan wrote:
> > On Sun, Apr 17, 2022 at 8:45 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
> >> On 4/17/22 8:34 PM, Alviro Iskandar Setiawan wrote:
> >>> On Sun, Apr 17, 2022 at 8:26 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
> >>>> On 4/17/22 8:06 PM, Alviro Iskandar Setiawan wrote:
> >>> [...]
> >>>>> Also, it needs persistent storage, container is temporary, but our
> >>>>> database is permanent???
> >>>>
> >>>> This is not a Dockerfile problem, it's a container problem. Which is
> >>>> done at `docker run`. So there is no relevance with mounting host's
> >>>> directory.
> >>>>
> >>>> The change is about Dockerfile. And we don't use a docker-compose.yml
> >>>> here. I don't see the need to involve that. Yes? No? Comment?
> >>>
> >>> Yes, but how do you tell other maintainers to mount the volume
> >>> correctly if you don't provide any mechanism in doing this? You should
> >>> tell us how to run it too!
> >>
> >> OK, I understand your concern.
> >>
> >> The database file that needs to be persistent lives in /var/lib/mysql.
> >>
> >> So:
> >>
> >>     docker run -v $HOST_DIR_FOR_MYSQL_DATA:/var/lib/mysql ...
> >>
> >> something like that...
> >>
> >> I will provide something for it in the v2. Anyway, since the mysql user
> >> is managed by a database as well, this will be persistent across docker
> >> run too. Hence, it's the host responsibility to retain the mysql users.
> >
> > I don't think we should retain mysql users! This may break with
> > different database versions, the "mysql" table is an internal thing
> > that shouldn't be exported. User setup should always be re-done at
> > initialization. Maybe you can put it in docker-entrypoint.sh????
>
> Huh, how come?
>
> By making the data persistent, I don't say we will export the "mysql"
> table. If we ever upgrade, we will export and import. But this persistent
> storage is meant to retain the data across docker run. Not across MySQL
> versions.
>
> Our automatic backup is always doing mysqldump and we don't export the
> "mysql" table here.

oc, tq

-- Viro