From: Alviro Iskandar Setiawan <[email protected]>
To: Muhammad Rizki <[email protected]>
Cc: Ammar Faizi <[email protected]>,
"GNU/Weeb Mailing List" <[email protected]>
Subject: Re: [PATCH v3 03/17] fix: utils: add a substr for the patch media caption
Date: Tue, 20 Dec 2022 07:29:15 +0700 [thread overview]
Message-ID: <CAOG64qOfVhTRtBaJbOw0tvUQLgprYZjZOb=VFtUQ+zGweA7X8A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
On Tue, Dec 20, 2022 at 6:57 AM Muhammad Rizki <[email protected]> wrote:
> Add a substr caption for the patch email to avoid media caption too
> long.
>
> Regarding this commit bb8855bf5e, it's forget to add a substr caption
> method, which is it will get media caption too long error for both
> Discord and Telegram bot.
>
> Signed-off-by: Muhammad Rizki <[email protected]>
What about changing the commit message to be something like this?
Commit bb8855bf5e3 ("Fix the storage management after the refactor was
happened") did not care with the caption length when sending an
attachment. This leads to error when the caption length hits the
limit. Add a substr() call to cut the caption if it's too long to
avoid such an error.
P.S.: <sic> at the "was happened" part.
next prev parent reply other threads:[~2022-12-20 0:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 23:57 [PATCH v3 00/17] RESEND: Fix, improvement and implement a bot logger Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 01/17] discord: Fix typo on _flood_exception() Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 02/17] fix: utils: Fix .patch file payload Muhammad Rizki
2022-12-20 0:15 ` Alviro Iskandar Setiawan
2022-12-20 0:18 ` Kiizuha
2022-12-19 23:57 ` [PATCH v3 03/17] fix: utils: add a substr for the patch media caption Muhammad Rizki
2022-12-20 0:29 ` Alviro Iskandar Setiawan [this message]
2022-12-20 1:59 ` Kiizuha
2022-12-20 8:13 ` Alviro Iskandar Setiawan
2022-12-19 23:57 ` [PATCH v3 04/17] fix: utils: Fix the extract_list() utility function Muhammad Rizki
2022-12-20 0:33 ` Alviro Iskandar Setiawan
2022-12-20 0:45 ` Ammar Faizi
2022-12-20 1:15 ` Alviro Iskandar Setiawan
2022-12-20 1:56 ` Kiizuha
2022-12-20 1:53 ` Kiizuha
2022-12-20 1:51 ` Kiizuha
2022-12-20 8:15 ` Alviro Iskandar Setiawan
2022-12-19 23:57 ` [PATCH v3 05/17] utils: Back to use decode=True for the get_payload() Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 06/17] utils: Improve fix_utf8_char() Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 07/17] utils: Add catch_err() for the log message Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 08/17] logger: Initial work for the bot logger for future use Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 09/17] telegram: Use the created BotLogger() class Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 10/17] telegram: Add variable LOG_CHANNEL_ID declaration Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 11/17] telegram: Add send_log_file() in the DaemonClient() Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 12/17] telegram: Implement the log message for catching errors Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 13/17] discord: Add variable LOG_CHANNEL_ID declaration Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 14/17] discord: Use the BotLogger() to the GWClient() Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 15/17] discord: Add send_log_file in " Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 16/17] discord: Implement the catch erros and logs Muhammad Rizki
2022-12-19 23:57 ` [PATCH v3 17/17] Remove some unused imports Muhammad Rizki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOG64qOfVhTRtBaJbOw0tvUQLgprYZjZOb=VFtUQ+zGweA7X8A@mail.gmail.com' \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox