Re: [PATCH gwproxy v0] epoll: Improve log readability and efficiency

[Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>]

On Sun, 17 Aug 2025 10:16:19 +0700, Ahmad Gani wrote:
> --- a/src/gwproxy/ev/epoll.c
> +++ b/src/gwproxy/ev/epoll.c
> @@ -325,24 +325,22 @@ static int __handle_ev_accept(struct gwp_wrk *w)
>         static const int flags = SOCK_NONBLOCK | SOCK_CLOEXEC;
>         struct gwp_ctx *ctx = w->ctx;
>         struct gwp_conn_pair *gcp;
> -       struct sockaddr *addr;
> +       struct gwp_sockaddr addr;
>         socklen_t addr_len;
>         int fd, r;
>
> +       addr_len = sizeof(addr);
> +       fd = __sys_accept4(w->tcp_fd, &addr.sa, &addr_len, flags);
> +       if (fd < 0)
> +               return handle_accept_error(w, fd);
> +
>         gcp = gwp_alloc_conn_pair(w);
>         if (unlikely(!gcp)) {
>                 pr_err(&ctx->lh, "Failed to allocate connection pair on accept");
>                 return handle_accept_error(w, -ENOMEM);
>         }

NAK.

If gwp_alloc_conn_pair() fails, you're leaking a TCP fd from
accept4(). After your changes, no one holds the returned fd except
that local variable.