From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alviro.iskandar@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS,
	URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no
	version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1755404690;
	bh=habtK0km9nu7oN67Wtyxc4ATHwKnyehjLs39HlTKiw0=;
	h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
	 To:Cc:Content-Type:Message-ID:Date:From:Reply-To:Subject:To:Cc:
	 In-Reply-To:References:Resent-Date:Resent-From:Resent-To:Resent-Cc:
	 User-Agent:Content-Type:Content-Transfer-Encoding;
	b=T+A3SjhiMuWJj9I5kODCMG8TUwm5UJ3GS8+LHgCNj9BofU3l7Y2Iz/m1Shg+E4sY1
	 r4t097rdz1X0PUJxFpSh7Ih992zz1MCzzxIDmezORUiwBTxrwu0IYdI5LOue+dvpXK
	 tx5xGzCkj3CLKyTLvOr+ubH1SGdUpAPew7Y45E6eQzjJSagNNe5TtmLVfZfoR4qD3K
	 ZZfFuXxc6Au1uzKN5FL6u7muZMDg8tQS1w0Ncpk9/y7VgQHS0MPiPWu6PXqKVrjIDp
	 WEdGk+YPYvTpb3E85Pf8zDdBRL+zjLDjgV4pNa6zb4ZLJABrf+vm6F3zioccH+IHsB
	 vXtjv/QD0Trtg==
Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id CA4C03127E59
	for <gwml@vger.gnuweeb.org>; Sun, 17 Aug 2025 04:24:50 +0000 (UTC)
Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-b47174c8e45so2894292a12.2
        for <gwml@vger.gnuweeb.org>; Sat, 16 Aug 2025 21:24:50 -0700 (PDT)
X-Forwarded-Encrypted: i=1; AJvYcCXqGpeY5ziLAtPAQ6LVxeq6rNqdAvNgOby0u1iR7m/1MN0O5fNgqFLDx7MSBRN5MljWpMEV@vger.gnuweeb.org
X-Gm-Message-State: AOJu0Yya1Vd+U862xvSM4psAP9s7pUFab2TOu9Wb4Y/cVxMe1Iu0+c7E
	2y4U9hwWdcgN8Ui6jxBNqYB6/fIcUkcksvTcCuezUgoYaPKjh66VmfF/av/DTLjrYMI/KwcH3wW
	GOxBV62JEsX97xeZXficpGpCu2mkDzBo=
X-Google-Smtp-Source: AGHT+IHESx50y2AAauT2KLUE5WrVUBN/50zUa/m9iE7DLOa9ezQgZy4k+Px7PxcwbnNtakox7djsHn7Ap024kTuEvAo=
X-Received: by 2002:a17:902:c94b:b0:242:9bbc:c773 with SMTP id
 d9443c01a7336-2446d982746mr96920035ad.54.1755404689186; Sat, 16 Aug 2025
 21:24:49 -0700 (PDT)
MIME-Version: 1.0
References: <20250817031621.81090-1-reyuki@gnuweeb.org>
In-Reply-To: <20250817031621.81090-1-reyuki@gnuweeb.org>
From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Date: Sun, 17 Aug 2025 11:24:38 +0700
X-Gmail-Original-Message-ID: <CAOG64qOiHK8K18jEzV6vgoWt4KT1U7iLczNB-D_=dCdiJUcmoQ@mail.gmail.com>
X-Gm-Features: Ac12FXx3_0caXCn_7tJptHA_D35kLKk9jR-xu07EgiL2dF4thBFGf4iyXMBH5BU
Message-ID: <CAOG64qOiHK8K18jEzV6vgoWt4KT1U7iLczNB-D_=dCdiJUcmoQ@mail.gmail.com>
Subject: Re: [PATCH gwproxy v0] epoll: Improve log readability and efficiency
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>, "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <gwml.vger.gnuweeb.org>

On Sun, 17 Aug 2025 10:16:19 +0700, Ahmad Gani wrote:
> --- a/src/gwproxy/ev/epoll.c
> +++ b/src/gwproxy/ev/epoll.c
> @@ -325,24 +325,22 @@ static int __handle_ev_accept(struct gwp_wrk *w)
>         static const int flags = SOCK_NONBLOCK | SOCK_CLOEXEC;
>         struct gwp_ctx *ctx = w->ctx;
>         struct gwp_conn_pair *gcp;
> -       struct sockaddr *addr;
> +       struct gwp_sockaddr addr;
>         socklen_t addr_len;
>         int fd, r;
>
> +       addr_len = sizeof(addr);
> +       fd = __sys_accept4(w->tcp_fd, &addr.sa, &addr_len, flags);
> +       if (fd < 0)
> +               return handle_accept_error(w, fd);
> +
>         gcp = gwp_alloc_conn_pair(w);
>         if (unlikely(!gcp)) {
>                 pr_err(&ctx->lh, "Failed to allocate connection pair on accept");
>                 return handle_accept_error(w, -ENOMEM);
>         }

NAK.

If gwp_alloc_conn_pair() fails, you're leaking a TCP fd from
accept4(). After your changes, no one holds the returned fd except
that local variable.