From: Alviro Iskandar Setiawan <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: Jens Axboe <[email protected]>,
"Fernanda Ma'rouf" <[email protected]>,
Hao Xu <[email protected]>,
Pavel Begunkov <[email protected]>,
io-uring Mailing List <[email protected]>,
"GNU/Weeb Mailing List" <[email protected]>
Subject: Re: [PATCH liburing v3 03/10] arch: syscall: Add `__sys_read()` syscall
Date: Tue, 5 Jul 2022 01:12:02 +0700 [thread overview]
Message-ID: <CAOG64qOvMW_UoSvHeMkwWJQST_CA7OAvP5ARJs12JjcQ8bCAPg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
On Tue, Jul 5, 2022 at 12:54 AM Ammar Faizi wrote:
> From: Ammar Faizi <[email protected]>
>
> A prep patch to support aarch64 nolibc. We will use this to get the
> page size by reading /proc/self/auxv.
>
> Signed-off-by: Ammar Faizi <[email protected]>
[...]
> +static inline int __sys_read(int fd, void *buffer, size_t size)
> +{
> + return (int) __do_syscall3(__NR_read, fd, buffer, size);
> +}
__sys_read should return ssize_t and the cast should also (ssize_t).
With that fixed:
Reviewed-by: Alviro Iskandar Setiawan <[email protected]>
tq
-- Viro
next prev parent reply other threads:[~2022-07-04 18:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 17:54 [PATCH liburing v3 00/10] aarch64 support Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 01/10] CHANGELOG: Fixup missing space Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 02/10] arch: syscall: Add `__sys_open()` syscall Ammar Faizi
2022-07-04 18:07 ` Alviro Iskandar Setiawan
2022-07-04 17:54 ` [PATCH liburing v3 03/10] arch: syscall: Add `__sys_read()` syscall Ammar Faizi
2022-07-04 18:12 ` Alviro Iskandar Setiawan [this message]
2022-07-04 18:16 ` Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 04/10] arch: Remove `__INTERNAL__LIBURING_LIB_H` checks Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 05/10] arch/aarch64: lib: Add `get_page_size()` function Ammar Faizi
2022-07-04 18:18 ` Alviro Iskandar Setiawan
2022-07-04 18:23 ` Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 06/10] lib: Style fixup for #if / #elif / #else / #endif Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 07/10] lib: Enable nolibc support for aarch64 Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 08/10] test: Add nolibc test Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 09/10] .github: Enable aarch64 nolibc build for GitHub bot Ammar Faizi
2022-07-04 17:54 ` [PATCH liburing v3 10/10] CHANGELOG: Note about aarch64 support Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOG64qOvMW_UoSvHeMkwWJQST_CA7OAvP5ARJs12JjcQ8bCAPg@mail.gmail.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox