From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
"GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v8 2/2] gwproxy: refactor code base to add experimental raw DNS backend
Date: Sat, 6 Sep 2025 14:14:10 +0700 [thread overview]
Message-ID: <CAOG64qP0n8k+1bUs0heZC8vMSs_fH1RKTDdbqm2EcqZ1xeZJJw@mail.gmail.com> (raw)
In-Reply-To: <CAOG64qN+BXH0S5YTzBrgY4JAJPd-TSDpiOd8YSirU=BA0hUy2Q@mail.gmail.com>
On Fri, Sep 5, 2025 at 11:26 PM Alviro Iskandar Setiawan wrote:
> > + if (w->ctx->cfg.use_raw_dns) {
> > +#ifdef CONFIG_RAW_DNS
> > + arm_poll_for_raw_dns_query(w, gcp);
> > +
> > + r = __sys_epoll_ctl(w->ep_fd, EPOLL_CTL_ADD, gde->udp_fd, &ev);
> > if (unlikely(r))
> > - return r;
> > + return (int)r;
> > +#endif
> > + } else {
>
> Bad indentation.
Back to this section. Apart from that, the
arm_poll_for_raw_dns_query() call here does not seem to care about
what happens in __sys_sendto(). What if it fails?
next prev parent reply other threads:[~2025-09-06 7:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 7:55 [PATCH gwproxy v8 0/2] Initial work on integration of DNS parser lib in gwproxy Ahmad Gani
2025-08-29 7:55 ` [PATCH gwproxy v8 1/2] dnsparser: Add dns parser code Ahmad Gani
2025-08-29 7:55 ` [PATCH gwproxy v8 2/2] gwproxy: refactor code base to add experimental raw DNS backend Ahmad Gani
2025-09-05 16:26 ` Alviro Iskandar Setiawan
2025-09-06 4:32 ` Ahmad Gani
2025-09-06 5:16 ` Ahmad Gani
2025-09-06 6:17 ` Ahmad Gani
2025-09-06 6:48 ` Ahmad Gani
2025-09-06 7:02 ` Alviro Iskandar Setiawan
2025-09-06 6:47 ` Alviro Iskandar Setiawan
2025-09-09 2:38 ` reyuki
2025-09-06 11:27 ` Ahmad Gani
2025-09-06 12:01 ` Alviro Iskandar Setiawan
2025-09-06 12:58 ` Ahmad Gani
2025-09-06 13:30 ` Alviro Iskandar Setiawan
2025-09-06 13:44 ` Alviro Iskandar Setiawan
2025-09-06 14:26 ` Ahmad Gani
2025-09-06 14:30 ` Alviro Iskandar Setiawan
2025-09-07 4:22 ` Ammar Faizi
2025-09-07 5:57 ` Ammar Faizi
2025-09-07 6:39 ` Ahmad Gani
2025-09-07 6:40 ` Ahmad Gani
2025-09-07 6:43 ` Ammar Faizi
2025-09-07 7:06 ` Ammar Faizi
2025-09-07 7:17 ` Ahmad Gani
2025-09-07 9:52 ` Ahmad Gani
2025-09-07 10:19 ` Ammar Faizi
2025-09-07 10:36 ` Ahmad Gani
2025-09-06 7:14 ` Alviro Iskandar Setiawan [this message]
2025-09-06 7:21 ` Ahmad Gani
2025-09-06 7:47 ` Alviro Iskandar Setiawan
2025-09-06 11:01 ` Ahmad Gani
2025-09-05 9:18 ` [PATCH gwproxy v8 0/2] Initial work on integration of DNS parser lib in gwproxy Ammar Faizi
2025-09-05 9:34 ` Alviro Iskandar Setiawan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOG64qP0n8k+1bUs0heZC8vMSs_fH1RKTDdbqm2EcqZ1xeZJJw@mail.gmail.com \
--to=alviro.iskandar@gnuweeb.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
--cc=reyuki@gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox