Re: [PATCH gwproxy v4 5/6] dnsparser: Transaction id creation is delegated to caller

[Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>]

On Wed, Aug 6, 2025 at 5:21 PM Ahmad Gani wrote:
> Err.. How do you usually clean up commits like this? I accidentally amended
> the changes to the current commit, and splitting it manually without a diff
> seems like a nightmare. Is there a way to make splitting a patch easier?

What do you mean by "splitting it manually without a diff"?

I don't understand the exact activity you meant.

This splitting problem is because you didn't do it in the first place.
I don't often do that.

You can unstage the unrelated hunk, then amend a previous commit to
apply the same changes where that hunk should be applied.

That's just one hunk specific to variable reordering, it should not be
a problem. If you had a large chunk, you could copy the hunk and apply
it using "git apply" anw.

But this one is not a nightmare, this is just one line change.

And even If you lost the change due to a mistake in performing "git
commit --amend", you can still fetch the old changes from git reflog.

And even if your git reflog is fully destroyed, you still have the
patches you sent via email that can be reapplied, resulting in the
same git history, just that with different SHA1 hashes.

-- Viro