From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alviro.iskandar@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS,
	URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no
	version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1755157425;
	bh=rE/utaoIGGFJQNGHiCoGQ117kCZ7S42s2rJaf5ZDKkE=;
	h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
	 To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From:
	 Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date:
	 Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type:
	 Content-Transfer-Encoding;
	b=LfhdRxx9piLKiv/ulBzF/rWQcWGpbyQ/CJXBsK970xzMo+vMDoHIIe2icN3LsQncK
	 wj9CSZeFSkoMAeIq4QXar31roggQ4fojlDAQRsOiMTWq6Ktn1gsWyTuV7lAJbhkIJc
	 h7tWlRvOLU0TFwpymJegHoDkl/Lak3sW8AfWQXRno00kxGg7DRwk4nZXWR/mL6vWGf
	 ZJHJOEfFYdfGytpFQ63bvzGGB9BHv2toEKnEksjhUl7C7h7ClcXeqzDzPjjiYuF/HY
	 4XDq1x39H6MPrAJgU9aoBjdxTiXpe2qJTeyoX0Tyq75B7eAL+vCbZdB8MLl0tChYOu
	 R8LqinvEPiqbQ==
Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 846133127F9D
	for <gwml@vger.gnuweeb.org>; Thu, 14 Aug 2025 07:43:45 +0000 (UTC)
Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-32326e05b3eso526269a91.2
        for <gwml@vger.gnuweeb.org>; Thu, 14 Aug 2025 00:43:45 -0700 (PDT)
X-Forwarded-Encrypted: i=1; AJvYcCU/v4270cy/hm19JGeBAryy9K66qb6rXjRCW/krAwzIkPqQ4Pz9K3OQVfwdNjmJhHMXkkcR@vger.gnuweeb.org
X-Gm-Message-State: AOJu0YycLlQsxPqMtkrII1pbbSKHgRGfLhy8bqlUIFsIcBz1Cu6xXikQ
	PREbCa6oikmFQOlS3KzHXOTJbQwQ/FivFb++KgGWmqQrxNZzswF4/NcsEwGR1aVIn8s0sVjbhcw
	Iy1JDm3If8p3ciY2TUWNlnsu9UhLrxyE=
X-Google-Smtp-Source: AGHT+IFQs6Y+BQsM5xoeXjVIGiNhkZR75T6Ke3O00KwRvE6vJPSx04OSyYGVhz8dB93/5fJGcxr79KP3DRTdVdAtEy4=
X-Received: by 2002:a17:90b:5630:b0:31f:ca:63cd with SMTP id
 98e67ed59e1d1-3232795b07fmr3322334a91.2.1755157423899; Thu, 14 Aug 2025
 00:43:43 -0700 (PDT)
MIME-Version: 1.0
References: <20250814044658.252579-1-reyuki@gnuweeb.org> <20250814044658.252579-3-reyuki@gnuweeb.org>
 <CAOG64qNhvV7-GeYKqBCjQJwCR5YboGv-1=ktregh8S8ThRCeNA@mail.gmail.com>
In-Reply-To: <CAOG64qNhvV7-GeYKqBCjQJwCR5YboGv-1=ktregh8S8ThRCeNA@mail.gmail.com>
From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Date: Thu, 14 Aug 2025 14:43:32 +0700
X-Gmail-Original-Message-ID: <CAOG64qPEQ5Ng4knsDbo_e8TKdGe5oQeK481+Gs5BTdeFM9RdAg@mail.gmail.com>
X-Gm-Features: Ac12FXxX8krYRww_YWAxWzeSEOyGj_wV38zaolk8AMHs1O4dNqx1lNmK7bZmxSg
Message-ID: <CAOG64qPEQ5Ng4knsDbo_e8TKdGe5oQeK481+Gs5BTdeFM9RdAg@mail.gmail.com>
Subject: Re: [PATCH gwproxy v5 2/2] dnsparser: Add dns parser code
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>, "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <gwml.vger.gnuweeb.org>

On Thu, Aug 14, 2025 at 2:28=E2=80=AFPM Alviro Iskandar Setiawan wrote:
> I think free(item); can be deduplicated. It's repeated several times
> here. Consider using goto exit_free_item and add the appropriate
> label. Do the same to other places if you have the same pattern
> elsewhere.

Oh, that's inside a for loop. Sorry, ignore my comment. That's indeed
not so good to be deduplicated. I thought it was not part of a
for-loop.