Re: [PATCH v2 05/11] telegram: Implement the DaemonException() and refactor report_err()

[Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>]

On Sun, Jan 8, 2023 at 1:36 PM Ammar Faizi wrote:
> On Sun, Jan 08, 2023 at 01:15:37PM +0700, Muhammad Rizki wrote:
> > @@ -77,8 +78,9 @@ class Bot():
> >                               await self.__handle_atom_url(url)
> >               except (OperationalError, DatabaseError) as e:
> >                       await self.handle_db_error(e)
> > -             except:
> > -                     await self.client.report_err(url)
> > +             except DaemonException as e:
> > +                     e.set_atom_url(url)
> > +                     await self.client.report_err(e)
>
> What is wrong with you?
>
> I have told you like 3 times about this. You need to handle a generic
> exception as well. Because if it throws an exception inside
> `self.db.get_atom_urls()`, we will not get the report.
>
> An exception that is raised inside `self.db.get_atom_urls()` will not
> be converted into a DaemonException instance. That is why it's possible
> to get an exception that's not an instance of (OperationalError,
> DatabaseError, DaemonException).

Maybe you need to give a small pseudo-code so it's clear to him. My
understanding will be adding an "except" statement without specifying
any exception class name, no?