From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alviro.iskandar@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED
	autolearn=no autolearn_force=no version=3.4.6
Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179])
	by gnuweeb.org (Postfix) with ESMTPSA id 16CA281665
	for <gwml@vger.gnuweeb.org>; Fri, 18 Nov 2022 02:31:01 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1668738661;
	bh=aojMmZpdEgWYKbg3+61bWNjADDeMUHbsrKONeMcFbGk=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=HXHfaUyzjpSAQrlCFwu9yNs3BKPaCBPADMi+v1Gtdh3MLOBYtOmnKSh7nCGUOtOZK
	 H4Y+gGgoocKFtw+PlX8gfGKxM23zt6wZ9IN0O6au6SfO4BLU5KFgaWf8BRRuXK148K
	 TmPp6XgIdYbsqLKmIKMpv7CnAimxEa9I1OVj4+qOYhcu1mkbbDkya5DLl5U7B63o9p
	 EJKzR3G7rntFGHRdC9dd9KpkmZsqzN1sD0xa/DJ3awHie5kDBZmyI8yQucub93MhvL
	 i7T1Xb+/fpldBMedziyX9BvzGbnjDO25MI1JZCbXWcqxOmHDARDMLzilVlnBXkuEB8
	 LrQHnEgJjpZsA==
Received: by mail-lj1-f179.google.com with SMTP id z24so5148732ljn.4
        for <gwml@vger.gnuweeb.org>; Thu, 17 Nov 2022 18:31:00 -0800 (PST)
X-Gm-Message-State: ANoB5plJjUUwVc40SSefTZRfXa/Np5o5gHhvnNR3jopX3LkbDKUen9kF
	PyCx3zr3KBtvCXu0a0RQYgfglCMFVOSNWHrgRbs=
X-Google-Smtp-Source: AA0mqf7cMGV3usvZ/nfbMm1YqhBB5nZVK9QD08ynpo7x+SAf0CfJpMAT21uS+d7jxCRXahqe8eiz0bKKqYR+cNORoko=
X-Received: by 2002:a05:651c:b0e:b0:277:3ca2:dac6 with SMTP id
 b14-20020a05651c0b0e00b002773ca2dac6mr1764553ljr.143.1668738659131; Thu, 17
 Nov 2022 18:30:59 -0800 (PST)
MIME-Version: 1.0
References: <20221117172729.2302627-1-ammarfaizi2@gnuweeb.org>
In-Reply-To: <20221117172729.2302627-1-ammarfaizi2@gnuweeb.org>
From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Date: Fri, 18 Nov 2022 09:30:47 +0700
X-Gmail-Original-Message-ID: <CAOG64qPNhJcRo72b1CXSfTi9QwSha-WjXTjLLtHb2HEgRyQ-eQ@mail.gmail.com>
Message-ID: <CAOG64qPNhJcRo72b1CXSfTi9QwSha-WjXTjLLtHb2HEgRyQ-eQ@mail.gmail.com>
Subject: Re: Fix data corruption bug
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Gilang Fachrezi <gilang4321@gmail.com>, Muhammad Rizki <kiizuha@gnuweeb.org>, 
	Dina Maulina <dina.m@amikom.ac.id>, Kernel Team <kernel-team@vnlx.org>, 
	Network Integration Team <netdev@vnlx.org>, "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <gwml.vger.gnuweeb.org>

On Fri, Nov 18, 2022 at 12:27 AM Ammar Faizi wrote:
> From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> Subject: [PATCH] chnet: Fix data corruption when a read operation is pending
>
> When a read operation is pending, the @read_ret_ variable has to be
> set to -EINPROGRESS. The current CHNetDelegate::__Read() method
> doesn't do that. This situation makes the caller abort the request
> because it doesn't see -EINPROGRESS from the return value. This bug
> is reproducible on a slow network connection where __Read()
> operation often results in a pending state.
>
> This bug is introduced in commit 77bbcc903899 ("chnet: Completely
> refactor again").
>
> Fixes: 77bbcc903899 ("chnet: Completely refactor again")
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>

Reviewed-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>

tq

-- Viro