Re: [PATCH gwproxy v1 1/3] dnslookup: split common functionality and struct into net.c

[Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>]

On Fri, Aug 1, 2025 at 1:53 AM Ammar Faizi wrote:
> On Fri, Aug 01, 2025 at 01:42:41AM +0700, Alviro Iskandar Setiawan wrote:
> > Ah, ic ic. I didn't know that. So it's fine to keep using glibc's
> > getaddrinfo() to initialize ares?
>
> Yes, it's fine at initialization. Cold paths are NOT something we
> should further optimize. The point of this pollable DNS resolver plan
> is to optimize hot paths. That's the event loop.
>
> But since that initialization needs a default port. The function
> convert_str_to_ssaddr() may be modified to handle IP addr with no port.
>
> Maybe something like:
>
>   static int convert_str_to_ssaddr(const char *str, struct gwp_sockaddr *gs, uint16_t default_port);
>
> After that, gw_ares_init() can use convert_str_to_ssaddr() with
> default_port=53.

Sounds good to me.

-- Viro