public inbox for [email protected]
 help / color / mirror / Atom feed
From: Alviro Iskandar Setiawan <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: "GNU/Weeb Mailing List" <[email protected]>,
	 Alviro Iskandar Setiawan <[email protected]>
Subject: Re: test debug
Date: Sun, 6 Mar 2022 18:15:40 +0700	[thread overview]
Message-ID: <CAOG64qPb3Gep8aXvGY0hoisE--ZO5hMQaQPkLhvxRFWP-r1rqg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>

On Sun, Mar 6, 2022 at 6:12 PM Ammar Faizi wrote:
> On 3/6/22 6:08 PM, Alviro Iskandar Setiawan wrote:
> > On Sun, Mar 6, 2022 at 6:04 PM Ammar Faizi wrote:
> > > On 3/6/22 6:03 PM, Alviro Iskandar Setiawan wrote:
> > > > test again
> > >
> > > Got your email!
> > >
> >
> > I think this regex is wrong sir, if the message-id is located at the
> > end of the header, we will not have double LF, because it's already
> > split by the explode.
> >
> > if (!preg_match("/(?:^|\\n)message-id:\s+?(.+?)(?:\\n\S+\:|\\n\\n)/si",
> > $hdr, $m)) {
> >          $err = "Cannot get the \"message-id\" line";
> >          goto out;
> > }
>
> Oh right, I forgot that we've already split it before parsing.
>
> > maybe we should use this:
> >
> >     "/(?:^|\\n)message-id:\s+?(.+?)(?:\\n\S+\:|$)/si"
>
> That one looks good to me, we should also fix other headers too.

I will send a patch to fix this, maybe tonight

-- Viro

  reply	other threads:[~2022-03-06 11:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-06 10:49 test debug Alviro Iskandar Setiawan
2022-03-06 10:53 ` Ammar Faizi
2022-03-06 11:01 ` Ammar Faizi
2022-03-06 11:03 ` Alviro Iskandar Setiawan
2022-03-06 11:04   ` Ammar Faizi
2022-03-06 11:08     ` Alviro Iskandar Setiawan
2022-03-06 11:12       ` Ammar Faizi
2022-03-06 11:15         ` Alviro Iskandar Setiawan [this message]
2022-03-06 13:00           ` Alviro Iskandar Setiawan
2022-03-06 13:06             ` Ammar Faizi
2022-03-06 13:10               ` Alviro Iskandar Setiawan
2022-03-06 13:13                 ` Faris Suryanto
2022-03-06 13:14                   ` Alviro Iskandar Setiawan
2022-03-06 13:17                     ` Alviro Iskandar Setiawan
2022-03-06 13:20                       ` Ammar Faizi
2022-03-06 13:25                         ` Alviro Iskandar Setiawan
2022-03-06 13:33                           ` Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOG64qPb3Gep8aXvGY0hoisE--ZO5hMQaQPkLhvxRFWP-r1rqg@mail.gmail.com \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox