From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1758236838; bh=FLPEpn61sZ3m+mkCFO5QxMdpibQmaMLGMj3AUIxykvk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=t8Jvcy4Hlsj2B/8WfS/2XrsZ067HYaBeEShPx9UbWU/zNwiEtA7MTNUwrDzyL2B6E Hxcz6OXBVufN9hc4HHw5H5AVVVWqfICpafKtfk1GMvPg3ZOgffaQ6ybkr6n5hNvJCz RbjE3n/SmI+uUbvezNnJLkuiXL4aJUxW19Ir9DiklVdC8LdN4N7XuGfzh0QF/enMaN oOlQDkOn5wIVv5FezH4GCUbVdOxVJmCl7y5i+c/8SmDx4WF4SklbpYKdI6UmKA8EcC QaF9k+JwFsBryMY0OuZTF5HMpMvbvGiQgQH+I4YeWeQbruhmVgOx4nWyiXOI0BFHQb Mh2SRfnl7qgBA== Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 94595312799E for ; Thu, 18 Sep 2025 23:07:18 +0000 (UTC) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7761b392d50so2035099b3a.0 for ; Thu, 18 Sep 2025 16:07:18 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCX7bKQlap9qMCqmbMIzBN43bQ49G8Rdg51thrlyZqKnCw3eSqBq3SKNturvkjTYT1KokS9+@vger.gnuweeb.org X-Gm-Message-State: AOJu0YzYDSRuwk2E+Ye26vRVXc8rFpFnuyJu//W4zZvZ3fDrdlFadizT kntROWrtizUEgLi/1NWQ34SPvMD/PdALrEwpN26YWlj7coTgbV5ul8oKCTnrPinkAh7J1oUsPce pzKS940sfhNAfEbSqjlFGmke/+T2WIAE= X-Google-Smtp-Source: AGHT+IHe2hGWB0szTBqlEHnFlCM9NNdpSjs2I+C8QrwxVW9llXq15KaYEx4ISNVbI608Zyy21tjA4YgWqrS7PVKrdOQ= X-Received: by 2002:a05:6a21:6da7:b0:24f:f79d:6696 with SMTP id adf61e73a8af0-29257e10bb9mr1702330637.2.1758236837029; Thu, 18 Sep 2025 16:07:17 -0700 (PDT) MIME-Version: 1.0 References: <20250918184730.598305-1-alviro.iskandar@gnuweeb.org> <20250918184730.598305-7-alviro.iskandar@gnuweeb.org> <20250918225421.GA1128776-ammarfaizi2@gnuweeb.org> In-Reply-To: <20250918225421.GA1128776-ammarfaizi2@gnuweeb.org> From: Alviro Iskandar Setiawan Date: Fri, 19 Sep 2025 06:07:05 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: AS18NWDQBd9TCfEwKsRmmOzOeEKph43ehZPjA5Xp_IM3wka7zNbfhvvSiHKNzKg Message-ID: Subject: Re: [PATCH gwproxy v12 6/8] gwproxy: Introduce --dns-server and --raw-dns To: Ammar Faizi Cc: Ahmad Gani , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Fri, Sep 19, 2025 at 5:54=E2=80=AFAM Ammar Faizi wrote: > I don't see any guard against the io_uring usage. Note that you only > add this feature support for epoll. Did you test and verify that your > feature addition doesn't break the io_uring event loop? Oh, that was an oversight. > Maybe you can add: > > if (cfg->use_raw_dns && !strcmp(cfg->event_loop, "io_uring)) { > fprintf(stderr, ERR_WRAP "Error: The raw DNS feature is c= urrently not supported with the io_uring event loop\n" ERR_WRAP); > goto einval; > } > > or something similar to avoid io_uring being run with the experimental > feature that's not available for it yet. I'll fold that addition in for v13. tq