Re: [ammarfaizi2-block:netdev/net-next/master 27/39] drivers/net/ethernet/sfc/efx_devlink.c:185:58: error: expected ')' before 'build_id'

["Lucero Palau, Alejandro" <alejandro.lucero-palau@amd.com>]

On 2/16/23 17:34, Paolo Abeni wrote:
> On Fri, 2023-02-17 at 00:12 +0800, kernel test robot wrote:
>> If you fix the issue, kindly add following tag where applicable
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@intel.com/
>> All errors (new ones prefixed by >>):
>>
>>     drivers/net/ethernet/sfc/efx_devlink.c: In function 'efx_devlink_info_running_v2':
>>>> drivers/net/ethernet/sfc/efx_devlink.c:185:58: error: expected ')' before 'build_id'
>>       185 |                 memset(&build_date, 0, sizeof(build_date)
>>           |                       ~                                  ^
>>           |                                                          )
>>       186 | #endif
>>       187 |                 build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_SUCFW_CHIP_ID);
>>           |                 ~~~~~~~~
>>>> drivers/net/ethernet/sfc/efx_devlink.c:197:55: error: expected ';' before '}' token
>>       197 |                                                  buf);
>>           |                                                       ^
>>           |                                                       ;
>>       198 |         }
>>           |         ~
> Alejandro, the bottom line is that your series need a follow-up as it
> breaks the build when CONFIG_RTC_LIB is not defined. I missed that at
> code review time.
>
> Could you please sent a fix (for net-next?)


Oh, what a shame!

I'll do it right now.

Thanks

>
> Thanks!
>
> Paolo
>