public inbox for [email protected]
 help / color / mirror / Atom feed
* [ammarfaizi2-block:netdev/net-next/master 27/39] drivers/net/ethernet/sfc/efx_devlink.c:185:58: error: expected ')' before 'build_id'
@ 2023-02-16 16:12 kernel test robot
  2023-02-16 17:34 ` Paolo Abeni
  0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2023-02-16 16:12 UTC (permalink / raw)
  To: Alejandro Lucero
  Cc: oe-kbuild-all, Ammar Faizi, GNU/Weeb Mailing List, Paolo Abeni,
	Jiri Pirko

tree:   https://github.com/ammarfaizi2/linux-block netdev/net-next/master
head:   40967f77dfa9fa728b7f36a5d2eb432f39de185c
commit: 14743ddd2495c96caa18e382625c034e49a812e2 [27/39] sfc: add devlink info support for ef100
config: ia64-randconfig-r036-20230213 (https://download.01.org/0day-ci/archive/20230217/[email protected]/config)
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/14743ddd2495c96caa18e382625c034e49a812e2
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block netdev/net-next/master
        git checkout 14743ddd2495c96caa18e382625c034e49a812e2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/net/ethernet/sfc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>
| Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

   drivers/net/ethernet/sfc/efx_devlink.c: In function 'efx_devlink_info_running_v2':
>> drivers/net/ethernet/sfc/efx_devlink.c:185:58: error: expected ')' before 'build_id'
     185 |                 memset(&build_date, 0, sizeof(build_date)
         |                       ~                                  ^
         |                                                          )
     186 | #endif
     187 |                 build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_SUCFW_CHIP_ID);
         |                 ~~~~~~~~                                  
>> drivers/net/ethernet/sfc/efx_devlink.c:197:55: error: expected ';' before '}' token
     197 |                                                  buf);
         |                                                       ^
         |                                                       ;
     198 |         }
         |         ~                                              


vim +185 drivers/net/ethernet/sfc/efx_devlink.c

   157	
   158			devlink_info_version_running_put(req,
   159							 EFX_DEVLINK_INFO_VERSION_FW_MGMT_CMC,
   160							 buf);
   161		}
   162	
   163		ver.words = (__le16 *)MCDI_PTR(outbuf, GET_VERSION_V2_OUT_VERSION);
   164		offset = snprintf(buf, EFX_MAX_VERSION_INFO_LEN, "%u.%u.%u.%u",
   165				  le16_to_cpu(ver.words[0]), le16_to_cpu(ver.words[1]),
   166				  le16_to_cpu(ver.words[2]), le16_to_cpu(ver.words[3]));
   167		if (flags & BIT(EFX_VER_FLAG(MCFW_EXT_INFO))) {
   168			build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_MCFW_BUILD_ID);
   169			snprintf(&buf[offset], EFX_MAX_VERSION_INFO_LEN - offset,
   170				 " (%x) %s", build_id,
   171				 MCDI_PTR(outbuf, GET_VERSION_V2_OUT_MCFW_BUILD_NAME));
   172		}
   173		devlink_info_version_running_put(req,
   174						 DEVLINK_INFO_VERSION_GENERIC_FW_MGMT,
   175						 buf);
   176	
   177		if (flags & BIT(EFX_VER_FLAG(SUCFW_EXT_INFO))) {
   178			ver.dwords = (__le32 *)MCDI_PTR(outbuf,
   179							GET_VERSION_V2_OUT_SUCFW_VERSION);
   180	#ifdef CONFIG_RTC_LIB
   181			tstamp = MCDI_QWORD(outbuf,
   182					    GET_VERSION_V2_OUT_SUCFW_BUILD_DATE);
   183			rtc_time64_to_tm(tstamp, &build_date);
   184	#else
 > 185			memset(&build_date, 0, sizeof(build_date)
   186	#endif
   187			build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_SUCFW_CHIP_ID);
   188	
   189			snprintf(buf, EFX_MAX_VERSION_INFO_LEN,
   190				 "%u.%u.%u.%u type %x (%ptRd)",
   191				 le32_to_cpu(ver.dwords[0]), le32_to_cpu(ver.dwords[1]),
   192				 le32_to_cpu(ver.dwords[2]), le32_to_cpu(ver.dwords[3]),
   193				 build_id, &build_date);
   194	
   195			devlink_info_version_running_put(req,
   196							 EFX_DEVLINK_INFO_VERSION_FW_MGMT_SUC,
 > 197							 buf);
   198		}
   199	}
   200	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-17  9:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-16 16:12 [ammarfaizi2-block:netdev/net-next/master 27/39] drivers/net/ethernet/sfc/efx_devlink.c:185:58: error: expected ')' before 'build_id' kernel test robot
2023-02-16 17:34 ` Paolo Abeni
2023-02-17  9:43   ` Lucero Palau, Alejandro

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox