From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <error27@gmail.com>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level:
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,
RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,
URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49])
by gnuweeb.org (Postfix) with ESMTPS id 516F28321E
for <gwml@vger.gnuweeb.org>; Wed, 1 Mar 2023 05:00:39 +0000 (UTC)
Authentication-Results: gnuweeb.org;
dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=H+L6jwMS;
dkim-atps=neutral
Received: by mail-ed1-f49.google.com with SMTP id h16so48999147edz.10
for <gwml@vger.gnuweeb.org>; Tue, 28 Feb 2023 21:00:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20210112; t=1677646837;
h=in-reply-to:content-transfer-encoding:content-disposition
:mime-version:references:message-id:subject:cc:to:from:date:from:to
:cc:subject:date:message-id:reply-to;
bh=u6tN4t92Y4qGgMiu8AHY6Saz3I11oSn1OtStmVFvLag=;
b=H+L6jwMS9o3dpRn+pHTCZBiVPFosZP8sF4htkBp6F7ZlXMJn67HNMI9BWRaloaKvRy
F/aA8ZwqZghSyj1Q7gNysvLGNtQgjCv0CLS6RjGVGPwGjbabYR+tgvTqvPOqmb0nq48J
nJ1aLD1jaB3EErHHnnY5BDtq+NvPEgmZHj1mAL2IaUbushceJ0SIai/XIF2Mv5jPTBVG
iLXiy2sKpyDDlZc51ZutzuUl9ALtjDYixs9LHSrBPZrr5TjVbmqajrYMm+t1rlmsrUhK
MiHaXV3YDYhwPmcWtuIYJGUxsHG3gOBQt7C2d30/0RhTsr810PCvA9nPcj9IWhtuBx6j
my3Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112; t=1677646837;
h=in-reply-to:content-transfer-encoding:content-disposition
:mime-version:references:message-id:subject:cc:to:from:date
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=u6tN4t92Y4qGgMiu8AHY6Saz3I11oSn1OtStmVFvLag=;
b=u+R0WTDoomMfkTkio68xdRwDv0deRuYLQfWC0lVtSq06cb6KJwWNTPoJYs24hqhuWf
d+8v/Uulfe6rYMQRgio2GktpiA/fXiAQZZcaVMt3kLzv+QHdDcUOfqt9f7yy5Uzq7BK6
+97nhnEEDQVyqrynMMX+pDxFzpZL/N2xWeDhl0hIwZpJuNmW6M4c5Qs5saUtSwMHqzf4
NFcncLNmw/aT1ne+Xa7fxVcfCbn834AQEtsAG5a5hbD9R/M+Jjg4VsQxCm3VBcj/0L6Y
qqaPJ0dpS79VPucN968z0CEDW0qR5cRm5lIF6Y1XB04wIc2K00OGUNsB7tvoyRi/9EOz
YWSQ==
X-Gm-Message-State: AO0yUKUJe0EmyoMkLTUKofVht64DPZ0lrmmBmZCsT7k3iB0HeMqdteHy
Zwv7MZ+V4ojMReONYkdnuAU=
X-Google-Smtp-Source: AK7set/kvCrA4tvNCNl0azoKo9wM48fBCa9n1J6HCUveUyJIRze73/W2wisqy+KW4ozadASFmLtDzQ==
X-Received: by 2002:a17:906:d84:b0:88d:619:15fc with SMTP id m4-20020a1709060d8400b0088d061915fcmr3573692eji.21.1677646837640;
Tue, 28 Feb 2023 21:00:37 -0800 (PST)
Received: from localhost ([102.36.222.112])
by smtp.gmail.com with ESMTPSA id qx27-20020a170906fcdb00b008bda61ff999sm5296248ejb.130.2023.02.28.21.00.36
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 28 Feb 2023 21:00:37 -0800 (PST)
Date: Wed, 1 Mar 2023 08:00:33 +0300
From: Dan Carpenter <error27@gmail.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: oe-kbuild@lists.linux.dev, lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Ammar Faizi <ammarfaizi2@gnuweeb.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [ammarfaizi2-block:akpm/mm/mm-unstable 82/99] mm/mmap.c:516
vma_prepare() error: we previously assumed 'vp->vma' could be null (see line
505)
Message-ID: <Y/7b8XRYIfJ08L3t@kadam>
References: <202302281802.J93Nma7q-lkp@intel.com>
<CAJuCfpHz3uECOuk6rRrV6Vn5r7+vn8HnC5cY7OZVHtGsAeE11A@mail.gmail.com>
<CAJuCfpHZS8_QNDoNLO2Ti2ZY26h7E8RrBtiKZ2zhY2cEvXQ1kw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJuCfpHZS8_QNDoNLO2Ti2ZY26h7E8RrBtiKZ2zhY2cEvXQ1kw@mail.gmail.com>
List-Id: <gwml.vger.gnuweeb.org>
On Tue, Feb 28, 2023 at 06:28:36PM -0800, Suren Baghdasaryan wrote:
> On Tue, Feb 28, 2023 at 10:04 AM Suren Baghdasaryan <surenb@google.com> wrote:
> >
> > On Tue, Feb 28, 2023 at 6:24 AM Dan Carpenter <error27@gmail.com> wrote:
> > >
> > > tree: https://github.com/ammarfaizi2/linux-block akpm/mm/mm-unstable
> > > head: 61edd3b68c3185673c9b05dfe48038692964c73b
> > > commit: f517f7ae341d933856cdf4d9d773027681ed5dff [82/99] mm/mmap: write-lock VMAs in vma_prepare before modifying them
> > > config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20230228/202302281802.J93Nma7q-lkp@intel.com/config)
> > > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> > >
> > > If you fix the issue, kindly add following tag where applicable
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Reported-by: Dan Carpenter <error27@gmail.com>
> > > | Link: https://lore.kernel.org/r/202302281802.J93Nma7q-lkp@intel.com/
> >
> > Thanks for reporting!
> >
> > >
> > > smatch warnings:
> > > mm/mmap.c:516 vma_prepare() error: we previously assumed 'vp->vma' could be null (see line 505)
> > >
> > > vim +516 mm/mmap.c
> > >
> > > 440703e082b9c7 Liam R. Howlett 2023-01-20 503 static inline void vma_prepare(struct vma_prepare *vp)
> > > 440703e082b9c7 Liam R. Howlett 2023-01-20 504 {
> > > f517f7ae341d93 Suren Baghdasaryan 2023-02-27 @505 if (vp->vma)
> > >
> > > Check presumes that vp->vma can be NULL. On my other system (with
> > > yesterday's linux-next code) vp->vma can never be NULL.
> >
> > I think the check here is not needed since vp->vma should always be
> > non-NULL. I'll double-check and will remove it if that is confirmed.
>
> Fix is posted at
> https://lore.kernel.org/all/20230301022720.1380780-1-surenb@google.com/
Thanks!
regards,
dan carpenter