From: Greg Kroah-Hartman <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: kernel test robot <[email protected]>,
Dave Hansen <[email protected]>,
[email protected], [email protected],
GNU/Weeb Mailing List <[email protected]>,
Sasha Levin <[email protected]>,
Thomas Gleixner <[email protected]>
Subject: Re: [ammarfaizi2-block:stable/linux-stable-rc/queue/5.4 15/15] kernel/bpf/core.c:1570:3: error: implicit declaration of function 'barrier_nospec'
Date: Thu, 23 Feb 2023 15:14:39 +0100 [thread overview]
Message-ID: <Y/[email protected]> (raw)
In-Reply-To: <Y/[email protected]>
On Thu, Feb 23, 2023 at 08:49:02PM +0700, Ammar Faizi wrote:
> On Thu, Feb 23, 2023 at 09:31:08PM +0800, kernel test robot wrote:
> > tree: https://github.com/ammarfaizi2/linux-block stable/linux-stable-rc/queue/5.4
> > commit: 3bb990ea37595b41a1f06a551e5dd35372ea404a [15/15] uaccess: Add speculation barrier to copy_from_user()
> ...
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <[email protected]>
> > | Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> >
> > All errors (new ones prefixed by >>):
> >
> > >> kernel/bpf/core.c:1570:3: error: implicit declaration of function 'barrier_nospec' [-Werror,-Wimplicit-function-declaration]
> > barrier_nospec();
> > ^
> > 1 error generated.
>
> It's missing #include <linux/nospec.h>. The fix for this is:
>
> Upstream f3dd0c53370e70c0f9b7e931bbec12916f3bb8cc ("bpf: add missing header file include")
>
> That one needs to get backported too. Or just fold that in to maintain
> the bisectability (for stable kernels).
Thanks, now queued up, I missed that follow-on patch.
greg k-h
prev parent reply other threads:[~2023-02-23 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 13:31 [ammarfaizi2-block:stable/linux-stable-rc/queue/5.4 15/15] kernel/bpf/core.c:1570:3: error: implicit declaration of function 'barrier_nospec' kernel test robot
2023-02-23 13:49 ` Ammar Faizi
2023-02-23 14:14 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox