Re: [PATCH v1 03/13] refactor(telegram)!: Ensure the Telegram bot has been started

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On Wed, Jan 04, 2023 at 01:39:35PM +0700, Alviro Iskandar Setiawan wrote:
> On Wed, Jan 4, 2023 at 1:31 PM Muhammad Rizki wrote:
> >         async def run(self):    # this is Bot() class
> >                 client.start()
> >
> >                 self.runner = self.sched.add_job(
> >                         func=self.__run,
> >                         misfire_grace_time=None,
> >                         max_instances=1
> >                 )
> >
> >                 self.sched.start()
> >                 idle()
> >                 client.stop()
> >
> > So, in the main file just call it `bot.run()`. What do you think?
> 
> Looks saner to me. With `self.client.xxxx()`.

I'm fine with this, but from I understand, there are two different
issues:

  1. Wrong ordering between 'client.start()' and 'sched.start()'.
     'client.start()' has to be called first because if an error
     happens before the report functional gets started, we won't get
     the report.

  2. Missing 'client.stop()' (IOW, missing graceful exit handler).

Calling 'client.start()' before 'sched.start()' fixes the former issue.
But the 'idle()' call fixes the later issue. That's why I'm asking to
have a separate patch for it. See what I'm saying? Or did I miss
something very clear here?

-- 
Ammar Faizi