From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED
	autolearn=no autolearn_force=no version=3.4.6
Received: from integral2 (unknown [182.253.183.184])
	by gnuweeb.org (Postfix) with ESMTPSA id 8EF737E443;
	Wed,  4 Jan 2023 07:05:12 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1672815913;
	bh=9ZUjD1fDg+T1mIP8pQulVifdfZcYGImbCzSI4Xb4NRs=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=fbARf3EGZy8Kp/qSOZuOtOfRthOvtNuIdfkrxVaWEup8VZwaEd2EvGEru4gsMckXZ
	 ScAqvpbqH7JIWIa0VEbd8prRbRLuWHg6T41egvmkr1+jiMJZcjznoJcJRgQol9Krcj
	 DtqWnsqyMIgKrbi4zKCgJW1DEI8YwAWdi8tHgdTiRmae++DD7VNiUitiGMsMfHoE0M
	 NgAJtcA2rS7gC4IsnrCzFPspclrIyxv2g7uTb4z8fDJwJOMmM2cGG0XRjAwUYdkhEJ
	 tLXCSuL647GR3DIDLZY2Dt/ebLfSvExMWt74gMt2aoF6Kx3TeRjA+QImrF26SoVwlE
	 p3ZlKBLhwkR7A==
Date: Wed, 4 Jan 2023 14:05:09 +0700
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Cc: Muhammad Rizki <kiizuha@gnuweeb.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH v1 03/13] refactor(telegram)!: Ensure the Telegram bot
 has been started
Message-ID: <Y7UlJYT+PTOvp2Ks@integral2>
References: <20230103063641.1680-1-kiizuha@gnuweeb.org>
 <20230103063641.1680-4-kiizuha@gnuweeb.org>
 <5fa120d7-32ab-b560-0c8f-0da64546cf0b@gnuweeb.org>
 <addc9394-d1b2-9a0a-9972-1a552048b0e7@gnuweeb.org>
 <d9fd0124-c4d8-0480-2ccb-79e3e22d2c9b@gnuweeb.org>
 <CAOG64qNKnFgqDHF=6N4s5q0mXCGX97gmHUvPZ-NY9Vn5zpcuyA@mail.gmail.com>
 <f269f829-6a22-452f-290b-fc005fa72a89@gnuweeb.org>
 <CAOG64qNgfpgDHzudZXfPf+tOBKqvJwD0=JpxNO8sar-4MRbg-A@mail.gmail.com>
 <Y7Uhr6utztMaDRcr@integral2>
 <CAOG64qNE3xrT14PBySBkYtULzC5hO=drERwDs6Vv-b5rJGfuSQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOG64qNE3xrT14PBySBkYtULzC5hO=drERwDs6Vv-b5rJGfuSQ@mail.gmail.com>
List-Id: <gwml.vger.gnuweeb.org>

On Wed, Jan 04, 2023 at 02:02:19PM +0700, Alviro Iskandar Setiawan wrote:
> I think we don't actually care with the former issue because it's at
> initialization, if the initialization fails, something has gone wrong
> at a fatal level and needs to be fixed immediately. No one needs the
> file report when it happens. So the subject itself should say:
> 
>    telegram: Perform graceful exit when interrupted by a signal
> 
> and then the changelog explains the need of calling idle() and
> client.stop(). Not the ordering issue.

Good point. Let's do that.

-- 
Ammar Faizi