From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED
	autolearn=no autolearn_force=no version=3.4.6
Received: from biznet-home.integral.gnuweeb.org (unknown [182.253.183.184])
	by gnuweeb.org (Postfix) with ESMTPSA id AF32C7F937;
	Tue, 17 Jan 2023 23:10:11 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1673997013;
	bh=iNyQNABpvMTJdvMjYDBt8IM/5GQuFMr5q007yjoCSfY=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=Ok7seeQprN3/hHzuXttNqBV95f77z3WE/XnJuEAgYCXCrNfGOwF839CvED4DKjjN8
	 qy7Yq5Wp/nGgghrPMO+eB1OSgYvRc4uJeDa5wxe0JQj9wMhBKMtB8nIjMZldGO+chL
	 NHDRHxKY6HEl/F6vF1noY5KwRQz0Hb4tjuDBRA2Peu8OdB+TcSACtSGPsCuWoMiVrL
	 IE0oD//P1Vin7RrohJJPoQnJAU1mCtZ9USjPGbAAfwynsqEIL7vFPXtJKB2WxVDF+x
	 a4tTVYTv+cZJ8Qf6c22JKlNDa5IxpfbQFdLncN4fMceiuosXOtFQTBy26W6UTlO16i
	 WGJfN0tvrqhQQ==
Date: Wed, 18 Jan 2023 06:10:08 +0700
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Muhammad Rizki <kiizuha@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH v1 00/15] Everything about logger changes and some fixes
Message-ID: <Y8cq0BzYzicjVgJQ@biznet-home.integral.gnuweeb.org>
References: <20230117221216.1783-1-kiizuha@gnuweeb.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230117221216.1783-1-kiizuha@gnuweeb.org>
List-Id: <gwml.vger.gnuweeb.org>

On Wed, Jan 18, 2023 at 05:12:01AM +0700, Muhammad Rizki wrote:
> Hi sir,
> This series is about refactor logger method, fix charset issue, and some
> improvements. In this series we use a simple logging method that so
> easily to manage logger config using .conf file.
> 
> - What's new?
>   v1:
>     1) Add return type annotation for the send_text_mail() and
>        send_patch_email() for the Discord bot

This one breaks runtime:

    Traceback (most recent call last):
      File "/root/lore-daemon2/daemon/tg.py", line 11, in <module>
        from telegram.packages import DaemonTelegram
      File "/root/lore-daemon2/daemon/telegram/packages/__init__.py", line 1, in <module>
        from .client import DaemonTelegram
      File "/root/lore-daemon2/daemon/telegram/packages/client.py", line 17, in <module>
        from .decorator import handle_flood
      File "/root/lore-daemon2/daemon/telegram/packages/decorator.py", line 8, in <module>
        from typing_extensions import ParamSpec, ParamSpecArgs, ParamSpecKwargs
    ModuleNotFoundError: No module named 'typing_extensions'

Apparently, that happens because 'typing_extensions' module is missing.
But you didn't add that to the requirements.txt file. Apart from that,
I don't see anything immediately wrong. Overall, it looks good to me.

Please update the requirements.txt file together with that module
import addition.

-- 
Ammar Faizi