From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED
	autolearn=no autolearn_force=no version=3.4.6
Received: from biznet-home.integral.gnuweeb.org (unknown [182.253.183.184])
	by gnuweeb.org (Postfix) with ESMTPSA id BA40E7F884;
	Thu, 19 Jan 2023 06:54:32 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1674111274;
	bh=yBPWKxqV++CSKriaWSI9SzMU3vas2VDAIvfIZyva6Zc=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=lMB7zMtSJ9dWgzGfCbGL7n8ALraUZrAzEZmePtMGiN40r5MZMDiLdbbfvagKpjQog
	 eCBIpf10aoWx2ZHK69aq7Ya9RKe+TDakMn4ukoGHlnU74IVpHc9e/CxAOmd8yShBfg
	 cVCEkxpvziK4ecRRN2Hz9ol0kxV35xsBGibuzrBj4YeOvhrcdQXc8khvo0tdk5XngQ
	 oQ4TT8KfA+aOqBE60sY7ndTH1dsFrB5ktgiQ1NM1e12OA+t44dbPxiDCnzZr4R8N6q
	 +fpjdksu1mhrkxeGoesDAXB48y1B4wQKfG4ovFf027WrD2Az/5lALT8p3tqf/g/lSx
	 gZgAzpyd0rnVQ==
Date: Thu, 19 Jan 2023 13:54:29 +0700
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Muhammad Rizki <kiizuha@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH v2 00/17] Everything about logger changes and some fixes
Message-ID: <Y8jpJbXFkYcQaDG/@biznet-home.integral.gnuweeb.org>
References: <20230118175356.1853-1-kiizuha@gnuweeb.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230118175356.1853-1-kiizuha@gnuweeb.org>
List-Id: <gwml.vger.gnuweeb.org>

On Thu, Jan 19, 2023 at 12:53:39AM +0700, Muhammad Rizki wrote:
> - Patch 7 is to fix the type annotations for the Telegram's decorator.

You use 'typing_extensions' extension in patch #7.

> - Patch 16 is to move requirements.txt to the daemon and update deps.

But you add 'typing_extensions' in patch #16. This honestly, doesn't
make sense from the test standpoint. You should add 'typing_extensions'
to the requirement list first, then use it later. Each patch, when
applied, should not leave a breakage in the middle.

To save time and internet bandwith, I just reordered it myself because
it's simple enough for me to fix.

-- 
Ammar Faizi