Re: [ammarfaizi2-block:paulmck/linux-rcu/dev.2023.01.19a 55/61] kernel/rcu/rcutorture.c:3548 rcu_torture_init_srcu_lockdep() warn: for statement not indented

[Dan Carpenter <error27@gmail.com>]

On Wed, Jan 25, 2023 at 11:10:58AM +0300, Dan Carpenter wrote:
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:1265 rtl8188fu_phy_iq_calibrate() warn: re-using outside iterator: 'i'
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c:1168 rtl8723bu_phy_iq_calibrate() warn: re-using outside iterator: 'i'
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:3298 rtl8xxxu_gen1_phy_iq_calibrate() warn: re-using outside iterator: 'i'
> drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c:1989 rtl88e_phy_iq_calibrate() warn: re-using outside iterator: 'i'
> drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c:1429 rtl92c_phy_iq_calibrate() warn: re-using outside iterator: 'i'
> drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c:2294 rtl92d_phy_iq_calibrate() warn: re-using outside iterator: 'i'
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c:1393 rtl8723e_phy_iq_calibrate() warn: re-using outside iterator: 'i'
> drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c:2321 rtl8723be_phy_iq_calibrate() warn: re-using outside iterator: 'i'

These are all "false positives" (kind of).  It's 8 copies of code which
does:

	for (i = 0; i < 3; i++) {
		...
		if (i == 2) {
			for (i = 0; i < 8; i++)
				foo = bar[i];
		}
	}

So the loop exits with i == 8 instead of i == 3 but that doesn't matter.
Ugh...  Did the original author do this deliberately or did it just work
by chance?  I really prefer buggy code to code to ugly code.  With buggy
code it's a technical matter and easy to fix, but with ugly code that's
like a big debate and a social problem...

On the other hand, in this case, I don't think anyone is going to defend
the original style from these drivers so I may as well patch it.

regards,
dan carpenter