From: Nathan Chancellor <[email protected]>
To: Alviro Iskandar Setiawan <[email protected]>
Cc: Mark Brown <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>,
Codrin Ciubotariu <[email protected]>,
Nugraha <[email protected]>,
[email protected], [email protected],
[email protected], [email protected],
kernel test robot <[email protected]>
Subject: Re: [PATCH] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning
Date: Mon, 14 Mar 2022 15:06:54 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
Hi Alviro,
On Wed, Mar 09, 2022 at 06:58:49AM +0000, Alviro Iskandar Setiawan wrote:
> In function mchp_pdmc_af_put(), Intel's kernel test robot reports the
> following warning:
>
> sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array \
> 'uvalue->value.integer.value' will always evaluate to 'true' \
> [-Wpointer-bool-conversion]
>
> This is because we are using `uvalue->value.integer.value` which its
> type is `long value[128];` for conditional expression and that array
> will always decay to a non-NULL pointer. Using a non-NULL pointer for
> conditional expression will always evaluate to true.
>
> Fix this by changing it to `uvalue->value.integer.value[0]` as that's
> what the mchp_pdmc_af_get() function sets.
>
> To: Mark Brown <[email protected]>
> Cc: Codrin Ciubotariu <[email protected]>
> Cc: Nugraha <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
I would recommend removing these and just setting those values via git
send-email flags. In other words:
git send-email --to "..." --cc "..." --cc "..." <path to .patch>
and so on. It can cause a lot of spam if this patch is ever backported
or needed in other trees.
> Reported-by: kernel test robot <[email protected]>
> Link: https://lore.kernel.org/lkml/[email protected]
> Fixes: 50291652af5269813baa6024eb0e81b5f0bbb451 ("ASoC: atmel: mchp-pdmc: add PDMC driver")
This should be simplified to:
Fixes: 50291652af52 ("ASoC: atmel: mchp-pdmc: add PDMC driver")
I don't think the automated checkers will complain about that but the
short form is preferred.
> Signed-off-by: Alviro Iskandar Setiawan <[email protected]>
Thanks a lot for the patch!
Reviewed-by: Nathan Chancellor <[email protected]>
I don't know if those nits are worth resending but I do not see this
applied to Mark's tree yet. It might have gotten lost because this was
sent as a reply to the build report, rather than its own thread, which
has caused issues for me in the past:
https://lore.kernel.org/r/[email protected]/
If there is no action on this patch in the next couple of days, please
consider resending with the above nits addressed with Codrin's tag and
my tag.
> ---
> sound/soc/atmel/mchp-pdmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c
> index c44636f6207d..7b87f75c284c 100644
> --- a/sound/soc/atmel/mchp-pdmc.c
> +++ b/sound/soc/atmel/mchp-pdmc.c
> @@ -183,7 +183,7 @@ static int mchp_pdmc_af_put(struct snd_kcontrol *kcontrol,
> {
> struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
> struct mchp_pdmc *dd = snd_soc_component_get_drvdata(component);
> - bool af = uvalue->value.integer.value ? true : false;
> + bool af = uvalue->value.integer.value[0] ? true : false;
>
> if (dd->audio_filter_en == af)
> return 0;
>
> base-commit: 50291652af5269813baa6024eb0e81b5f0bbb451
> --
> 2.27.0
>
>
next prev parent reply other threads:[~2022-03-14 22:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 6:09 [ammarfaizi2-block:broonie/sound/for-next 13916/13921] sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array 'uvalue->value.integer.value' will always evaluate to 'true' kernel test robot
2022-03-09 6:58 ` [PATCH] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning Alviro Iskandar Setiawan
2022-03-09 7:55 ` Codrin.Ciubotariu
2022-03-14 22:06 ` Nathan Chancellor [this message]
2022-03-14 23:38 ` Alviro Iskandar Setiawan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox