From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, SPF_HELO_NONE,T_SPF_TEMPERROR,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by gnuweeb.org (Postfix) with ESMTPS id 761B47E342 for ; Sun, 3 Apr 2022 18:46:39 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (1024-bit key; unprotected) header.d=alien8.de header.i=@alien8.de header.a=rsa-sha256 header.s=dkim header.b=l59mXDjK; dkim-atps=neutral Received: from zn.tnic (p2e55dff8.dip0.t-ipconnect.de [46.85.223.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E98FD1EC03C9; Sun, 3 Apr 2022 20:46:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1649011594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=2HjVlEdlul+lX8f7wTuHDWSA2vrSz2EQiEfHXKjpjQA=; b=l59mXDjKhhUMPxGyiKT5DqGFArOaluj0rtOErU/Kmc6OR2Ykb0xgnSdo4Eyi1AISV5hs9z nw71ZvTedtXnzJMSILspBrlQg/TyemPcww0YQ225kU6gjbNS+er+UNOAhCEmtTd9/JsczC ipHhGjzNthdXa7Cj9jj7Qw1YsbxIdYU= Date: Sun, 3 Apr 2022 20:46:30 +0200 From: Borislav Petkov To: Ammar Faizi Cc: Thomas Gleixner , Alviro Iskandar Setiawan , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Tony Luck , Yazen Ghannam , Linux Edac Mailing List , Linux Kernel Mailing List , Stable Kernel , GNU/Weeb Mailing List , x86 Mailing List Subject: Re: [PATCH v6 2/2] x86/MCE/AMD: Fix memory leak when `threshold_create_bank()` fails Message-ID: References: <20220329104705.65256-1-ammarfaizi2@gnuweeb.org> <20220329104705.65256-3-ammarfaizi2@gnuweeb.org> <87wng6ksjl.ffs@tglx> <215ca9e7-b719-d5b8-c6db-1d71544d47be@gnuweeb.org> <00347b4a-e719-9dac-b42b-05a3f117fd46@gnuweeb.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <00347b4a-e719-9dac-b42b-05a3f117fd46@gnuweeb.org> List-Id: On Mon, Apr 04, 2022 at 12:45:04AM +0700, Ammar Faizi wrote: > > Yazen, Borislav, please take a deeper look on this again. I will send > > a v7 revision to really make it simpler by moving that "per-CPU var write" > > before the loop. > > (only if it's really safe) Don't bother - I've discussed it with tglx offlist. The current solution remains. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette